-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor startswith with path_isin util
#2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor startswith with path_isin util
#2832
Conversation
d391414 to
751bdb2
Compare
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, @skshetry !
|
@skshetry , for S3 we use When working with |
|
@MrOutis, yes, |
7472dad to
751bdb2
Compare
efiop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, thank you!
β Have you followed the guidelines in the Contributing to DVC list?
π Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
β Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Description
Resolves #2823
I did not feel brave enough ondvc.remote.s3.RemoteS3.exists.EDIT:
dvc.remote.s3.RemoteS3.existscannot be changed, aspath_isinis os-agnostic, whereas s3 requires posixpath.dvc/utils/__init__.py:260has a cyclic dependency problem.There are few other cases of
startswith, but are not related with filepaths (except fordvc/utils/__init__.pyat the end β¬)Thank you for the contribution - we'll try to review it as soon as possible. π