remote: small .save_info()/.get_checksum() cleanup #2835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
approved these changes
Nov 25, 2019
Contributor
pared
left a comment
pared
left a comment
There was a problem hiding this comment.
@Suor good catch. Approved.
Idea for another issue:
Do you think it would be a good idea to reconsider how we handle self.info in Output?
We assign it here and here.
Maybe we should initialize it as empty dict in the constructor instead of None, and fill it in mentioned places using get_checksum?
I think that self.info[PARAM_CHECKSUM] = self.get_checksum is more readable than
self.info = self.save_info, also that would let us remove save_info.
Contributor
Author
|
@pared This will really be self.info[self.remote.PARAM_CHECKSUM] = self.remote.get_checksum(self.path_info)which doesn't look that nice. |
Contributor
Author
|
@MrOutis may you take a look at it? |
Contributor
|
Thank you @Suor ! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.