Skip to content

test: refactor & remove redundant test fixtures #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

test: refactor & remove redundant test fixtures #2861

merged 1 commit into from
Nov 28, 2019

Conversation

@danihodovic
Copy link
Contributor

@danihodovic danihodovic commented Nov 28, 2019 •
edited
Loading

@danihodovic
Copy link
Contributor Author

danihodovic commented Nov 28, 2019

@pared @efiop

@danihodovic danihodovic force-pushed the refactor/remove-redundant-vars branch from 95187f3 to 78c505f Compare November 28, 2019 18:05
efiop
efiop approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@efiop efiop merged commit 6b4242a into treeverse:master Nov 28, 2019
@ghost
Copy link

ghost commented Nov 28, 2019

Thanks, @danihodovic !

@danihodovic danihodovic deleted the refactor/remove-redundant-vars branch November 28, 2019 23:28
@weekly-digest weekly-digest bot mentioned this pull request Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danihodovic @efiop