Skip to content

test: skip non supported remotes fast in api tests #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2019
Merged

test: skip non supported remotes fast in api tests #2870

merged 1 commit into from
Nov 30, 2019

Conversation

@Suor
Copy link
Contributor

@Suor Suor commented Nov 29, 2019

Use remote_url fixture first to skip a test before repo dir is created.

@efiop efiop assigned ghost and pared Nov 29, 2019
efiop
efiop approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@efiop efiop unassigned ghost and pared Nov 30, 2019
@efiop efiop merged commit 3084830 into treeverse:master Nov 30, 2019
@weekly-digest weekly-digest bot mentioned this pull request Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Suor @efiop @pared