remote: base: download: don't walk dir twice #2909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suor
approved these changes
Dec 6, 2019
| file_to_infos = ( | ||
| to_info / file_to_info.relative_to(from_info) | ||
| for file_to_info in self.walk_files(from_info) | ||
| from_infos = list(self.walk_files(from_info)) |
Contributor
There was a problem hiding this comment.
There might a significant delay here before we see pbar. May ignore this for now though.
Contributor
Author
There was a problem hiding this comment.
@Suor Very good point! It has similar reasons to what @shcheklein brought up in his -d s3://path/to/dir research(which is _collect_dir's fault). I'll fix it in #2911 .
Codecov Report
@@ Coverage Diff @@
## master #2909 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 137 137
Lines 8550 8550
=======================================
Hits 7805 7805
Misses 745 745
Continue to review full report at Codecov.
|
ghost
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏