test: migrate test_ignore #2913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suor
force-pushed
the
migrate-test-ignore
branch
from
72b0a13 to
f7e8e16
Compare
Suor
force-pushed
the
migrate-test-ignore
branch
from
f7e8e16 to
42096c5
Compare
Contributor
|
@Suor Windows tests failed, please take a look. |
Contributor
|
@Suor Still failing 🙁 |
Contributor
Author
|
@efiop debugging against travis ) |
Suor
force-pushed
the
migrate-test-ignore
branch
from
762f07b to
6c12a2e
Compare
ghost
reviewed
Dec 8, 2019
| def test_ignore_unicode(tmp_dir, dvc): | ||
| tmp_dir.gen({"dir": {"other": "text"}}) | ||
| # Path() doesn't handle unicode paths in Windows/Python 2 | ||
| # I don't know to debug it further, waiting till Python 2 EOL |
ghost
reviewed
Dec 8, 2019
pared
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.