Skip to content

Conversation

@Suor
Copy link
Contributor

@Suor Suor commented Dec 24, 2019

  • nested files are ignored
  • external dirs are not affected

Testing this to prevent unintended changes to this behavior. Related to #2974.

- nested files are ignored
- external dirs are not affected
@Suor Suor mentioned this pull request Dec 24, 2019
3 tasks
@Suor
Copy link
Contributor Author

Suor commented Dec 24, 2019

We should use pathlib2 in Python 3.5 to make it work with fspath() and accept other Path-like objects. See error here. This is a recurring issue when developing things.

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #3003 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   91.73%   91.52%   -0.22%     
==========================================
  Files         138      138              
  Lines        8704     8704              
==========================================
- Hits         7985     7966      -19     
- Misses        719      738      +19
Impacted Files Coverage Δ
dvc/system.py 80% <0%> (-8.47%) ⬇️
dvc/remote/ssh/connection.py 81.28% <0%> (-2.96%) ⬇️
dvc/analytics.py 95.89% <0%> (-1.37%) ⬇️
dvc/scm/git/__init__.py 88.15% <0%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd68e9a...5f3e416. Read the comment docs.

@Suor
Copy link
Contributor Author

Suor commented Dec 27, 2019

Looks like coverage report is broken. How adding a couple of tests can reduce coverage?

@efiop efiop merged commit 5a589c5 into treeverse:master Dec 27, 2019
@efiop
Copy link
Contributor

efiop commented Dec 27, 2019

@Suor Yeah, not sure why it suddenly popped up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants