repro: tests: migrate to dir helpers #3091
Conversation
pared
changed the title
tests/func/test_repro.py
Outdated
|
|
||
|
|
||
| def test_recursive_repro_empty_dir(dvc_repo, repro_dir): | ||
| def test_recursive_repro_empty_dir(dvc, repro_dir): |
There was a problem hiding this comment.
I presume that repro_dir was added here to make sure running repro, will not trigger any other stage?
There was a problem hiding this comment.
@pared I think it was only used for repro_dir.emtydname, so we can safely remove it.
pared
changed the title
| # | | | ||
| # \ / | ||
| # \ / | ||
| # dir/Dvcfile |
There was a problem hiding this comment.
You could've used tree CLI util, it would be much easier to understand than graph 🙂
There was a problem hiding this comment.
I intended to show dependency between particular stages, tree would show placement in the directory. I thought that this one brings more information. Maybe I should include both?
There was a problem hiding this comment.
Oh, right, sorry. Ok, why not dvc pipeline show --ascii then? Or is it too big?
There was a problem hiding this comment.
^ Just wondering, I'm okay with this illustration.
There was a problem hiding this comment.
@efiop, you are right, it was too big, had to to it my own way, so that we will still be able to pass all checks :)
2 participants
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Some summary:
run_copyrepro_dira bit clearerrepro_dirlooks like internally