Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jan 11, 2020

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #3113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3113   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         138      138           
  Lines        8514     8514           
=======================================
  Hits         7801     7801           
  Misses        713      713

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e97886...f31e395. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #3113 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3113      +/-   ##
=========================================
- Coverage   91.62%   91.5%   -0.12%     
=========================================
  Files         138     138              
  Lines        8514    8514              
=========================================
- Hits         7801    7791      -10     
- Misses        713     723      +10
Impacted Files Coverage Δ
dvc/compat.py 16.66% <0%> (-55.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e97886...d989663. Read the comment docs.

@efiop efiop closed this in f920afd Jan 12, 2020
@efiop efiop deleted the efiop-patch-1 branch January 13, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants