Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jan 21, 2020

URL should be required and rev or rev_lock should be optional.

Related to #3087

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

URL should be required and rev or rev_lock should be optional.

Related to treeverse#3087
@efiop efiop requested review from pared and skshetry January 21, 2020 12:01
Copy link
Collaborator

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@skshetry
Copy link
Collaborator

Is there anything left for #3087? I see #3151 is already merged.

@efiop
Copy link
Contributor Author

efiop commented Jan 21, 2020

@skshetry That issue also brings the question of expected behaviour when you import a directory that contains git files, dvc-files and dvc-tracked files. So not ready to close it yet πŸ™

@efiop efiop merged commit 6958901 into treeverse:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants