Skip to content

Conversation

@maxhora
Copy link
Contributor

@maxhora maxhora commented Jan 22, 2020

Fixes #3157

Secure env variable should be set by Travis before this PR is get merged.

@maxhora maxhora requested review from efiop and shcheklein January 22, 2020 20:22
@maxhora maxhora self-assigned this Jan 22, 2020
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shcheklein
Copy link
Contributor

@Maxris why is it WIP?

@maxhora
Copy link
Contributor Author

maxhora commented Jan 23, 2020

@shcheklein I've put [WIP] only to ensure that GDrive tests on Travis are running now (env variable should be set), so this PR will able to close the Issue #3157 as well.

@efiop
Copy link
Contributor

efiop commented Jan 23, 2020

@Maxris So is it still WIP? The env vars are only available for native branches as they are marked as secure ones, so this PR still shows that the tests are getting skipped. You could create a new PR from an upstream branch if you want to verify that tests are being ran before merging the PR.

@maxhora
Copy link
Contributor Author

maxhora commented Jan 23, 2020

@efiop thanks! I will check shortly. (Previously there was a bug or trick at GitHub that I can push branch with the same name to upstream and GitHub automatically will start treat this PR as from upstream's branch).

@maxhora maxhora changed the title [WIP] Update Google Project credentials to run tests Update Google Project credentials to run tests Jan 23, 2020
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #3216 into master will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3216      +/-   ##
==========================================
+ Coverage   91.67%   92.65%   +0.97%     
==========================================
  Files         139      139              
  Lines        8681     8681              
==========================================
+ Hits         7958     8043      +85     
+ Misses        723      638      -85
Impacted Files Coverage Δ
dvc/remote/base.py 95.4% <0%> (+0.19%) ⬆️
dvc/remote/gdrive.py 93.25% <0%> (+47.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99c5e4...cb38b1a. Read the comment docs.

@maxhora
Copy link
Contributor Author

maxhora commented Jan 23, 2020

@efiop not sure how it works, but pushing of the same branch to upstream have restart Travis build automatically and secured variables are in place this time. Can see that gdrive tests are passing, so please merge this PR

[gw1] [ 19%] PASSED tests/func/test_data_cloud.py::TestRemoteGDrive::test 
[gw0] [ 20%] PASSED tests/func/test_data_cloud.py::TestRemoteGDriveCLI::test 

@efiop
Copy link
Contributor

efiop commented Jan 23, 2020

Thanks @Maxris ! 🙏

@efiop efiop merged commit bbb3a83 into treeverse:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: GDrive tests are getting skipped.

3 participants