-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Google Project credentials to run tests #3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shcheklein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@Maxris why is it WIP? |
|
@shcheklein I've put [WIP] only to ensure that GDrive tests on Travis are running now (env variable should be set), so this PR will able to close the Issue #3157 as well. |
|
@Maxris So is it still WIP? The env vars are only available for native branches as they are marked as secure ones, so this PR still shows that the tests are getting skipped. You could create a new PR from an upstream branch if you want to verify that tests are being ran before merging the PR. |
|
@efiop thanks! I will check shortly. (Previously there was a bug or trick at GitHub that I can push branch with the same name to upstream and GitHub automatically will start treat this PR as from upstream's branch). |
Codecov Report
@@ Coverage Diff @@
## master #3216 +/- ##
==========================================
+ Coverage 91.67% 92.65% +0.97%
==========================================
Files 139 139
Lines 8681 8681
==========================================
+ Hits 7958 8043 +85
+ Misses 723 638 -85
Continue to review full report at Codecov.
|
|
@efiop not sure how it works, but pushing of the same branch to upstream have restart Travis build automatically and secured variables are in place this time. Can see that gdrive tests are passing, so please merge this PR |
|
Thanks @Maxris ! 🙏 |
Fixes #3157
Secure env variable should be set by Travis before this PR is get merged.