get/import: they don't work with any DVC project, only DVC repos (as well as Git repos) #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
added a commit
to treeverse/dvc.org
that referenced
this pull request
Feb 3, 2020
per treeverse/dvc/pull/3277 and precursor to merging DVC repo term into DVC project (glossary)
jorgeorpinel
added a commit
to treeverse/dvc.org
that referenced
this pull request
Feb 3, 2020
jorgeorpinel
added a commit
to treeverse/dvc.org
that referenced
this pull request
Feb 3, 2020
efiop
reviewed
Feb 4, 2020
3 tasks
Contributor
Author
|
pared
approved these changes
Feb 10, 2020
Contributor
|
Oops, sorry for the delay @jorgeorpinel ! |
efiop
approved these changes
Feb 10, 2020
Contributor
Author
|
Ah no problem, I didn't mean to rush you @efiop, I just wanted to put a checkbox there for myself not to forget about my next PR. Thanks though! |
Contributor
|
@jorgeorpinel Please feel free to ping me (e.g. in PMs) if I don't respond to something in one day, I do sometimes miss/lose some notifications. |
Contributor
Author
|
Thanks |
3 tasks
efiop
pushed a commit
that referenced
this pull request
Feb 17, 2020
* get/import: update cmd and url arg descs with correct behavior * get/import: update path arg desc as well (See previous commit) * get/imp: udpate help output with simpler terms per #3277 (review) * api: url->URL in a docstring * metrics show: update help output per per treeverse/dvc.org#933 (review) * diff: update `diff` and `metrics diff` help desc to match docs per treeverse/dvc.org#933 (review) * diff: update autocomplete scripts per #3308 (comment) * diff: update help output again per treeverse/dvc.org#933 (review) * diff/metrics diff: update help output yet again per treeverse/dvc.org#933 (comment) * term" under X control -> tracked by X
efiop
added a commit
that referenced
this pull request
Feb 17, 2020
* get/import: update cmd and url arg descs with correct behavior * get/import: update path arg desc as well (See previous commit) * get/imp: udpate help output with simpler terms per #3277 (review) * api: url->URL in a docstring * metrics show: update help output per per treeverse/dvc.org#933 (review) * diff: update `diff` and `metrics diff` help desc to match docs per treeverse/dvc.org#933 (review) * diff: update autocomplete scripts per #3308 (comment) * diff: update help output again per treeverse/dvc.org#933 (review) * diff/metrics diff: update help output yet again per treeverse/dvc.org#933 (comment) Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on v
0.82.6. I created a--no-scmproject and tried togetandimportfrom it to other locations, getting:❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
Docs update in doc: regular updates (late Jan) dvc.org#931 & Mostly link-related (regular) updates dvc.org#978
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏