dvc: introduce `dvc params diff` #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

efiop merged 5 commits into treeverse:master from efiop:3528

Apr 9, 2020

Contributor

efiop commented Apr 1, 2020 •

edited

Loading

❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

@dmpetrov Volunteered to provide docs for this with nice examples 🙏

❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

efiop changed the title ~~dvc: introduce dvc params diff~~ [WIP] dvc: introduce dvc params diff

efiop commented

View reviewed changes

dvc/command/params.py Outdated Show resolved Hide resolved

efiop commented

View reviewed changes

dvc/command/params.py Outdated Show resolved Hide resolved

efiop commented

View reviewed changes

dvc/remote/local.py Outdated Show resolved Hide resolved

efiop commented

View reviewed changes

dvc/repo/params/diff.py Outdated Show resolved Hide resolved

efiop commented

View reviewed changes

dvc/repo/params/show.py Outdated Show resolved Hide resolved

efiop commented

View reviewed changes

dvc/command/params.py Outdated Show resolved Hide resolved

efiop force-pushed the 3528 branch 2 times, most recently from f7052bd to b29c3e2 Compare

April 3, 2020 11:32

Contributor Author

efiop commented Apr 7, 2020 •

edited

Loading

Issues:

angles:          
    - 2          
    - 3          
    - 100        
    - 3.2        
    - 36.2       
    - 3.2        
df3: [1, 3]      
train:           
    lr: 0.0042   
    layers: 10   
    dropout: 0.21
processing:      
    th: 0.98     
    bow: 7000

diff for angles will be shown as angles.N where N is the number of the element that changed in the list. Need to treat them as lists. EDIT: fixed

And if you change train.lr to 0.0042, diff will show it as 0.004. These affect metrics diff too. EDIT: fixed.

efiop force-pushed the 3528 branch 3 times, most recently from 02b6c22 to 73cf495 Compare

April 7, 2020 15:47

efiop changed the title ~~[WIP] dvc: introduce dvc params diff~~ dvc: introduce dvc params diff

efiop requested a review from dmpetrov

April 7, 2020 16:18

efiop changed the title ~~dvc: introduce dvc params diff~~ [WIP] dvc: introduce dvc params diff

Contributor

Suor commented Apr 8, 2020 •

edited

Loading

@efiop when do you expect this to be merged?

Contributor Author

efiop commented Apr 8, 2020 •

edited

Loading

@Suor Need to implement support for targets (will do today) and get an approval from @dmpetrov . So maybe later today.

efiop force-pushed the 3528 branch 3 times, most recently from 26fd104 to 0b65eba Compare

April 8, 2020 12:57

efiop changed the title ~~[WIP] dvc: introduce dvc params diff~~ dvc: introduce dvc params diff

Ruslan Kuprieiev added 3 commits

April 9, 2020 01:06


          params: use repo.tree

715b0d2


          remote: local: use repo.tree for exists()

aaa0ae3


          param: handle missing params

efiop force-pushed the 3528 branch 2 times, most recently from 9dbe43c to 10e6a5c Compare

April 8, 2020 22:47


          stage: move status warning to debug

b5a8ad7

efiop force-pushed the 3528 branch 2 times, most recently from 9a47ea6 to b9f3697 Compare

April 9, 2020 00:17

efiop force-pushed the 3528 branch 5 times, most recently from e237722 to 385f255 Compare

April 9, 2020 01:49


          dvc: introduce dvc params diff

124e49c

Fixes treeverse#3528

efiop force-pushed the 3528 branch from 385f255 to 124e49c Compare

April 9, 2020 01:50

Contributor Author

efiop commented Apr 9, 2020

Ok, got aproval from Dmitry. Merging.

efiop merged commit c1ac6bb into treeverse:master

efiop deleted the 3528 branch

April 9, 2020 02:18

weekly-digest bot mentioned this pull request

Weekly Digest (5 April, 2020 - 12 April, 2020) #3627

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet