Skip to content

Conversation

@jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Apr 6, 2020

Followup to #3566 (review)

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@jorgeorpinel jorgeorpinel mentioned this pull request Apr 6, 2020
3 tasks
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #3601 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3601      +/-   ##
==========================================
- Coverage   90.91%   90.90%   -0.02%     
==========================================
  Files         143      143              
  Lines        9236     9236              
==========================================
- Hits         8397     8396       -1     
- Misses        839      840       +1     
Impacted Files Coverage Δ
dvc/command/diff.py 92.98% <ø> (ø)
dvc/command/init.py 100.00% <ø> (ø)
dvc/scm/__init__.py 100.00% <ø> (ø)
dvc/scm/base.py 87.93% <ø> (ø)
dvc/output/base.py 95.45% <100.00%> (ø)
dvc/updater.py 54.65% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca60c8e...7d8046a. Read the comment docs.

@jorgeorpinel jorgeorpinel changed the title diff: update help output to match docs diff: update help output to match docs, et al. Apr 7, 2020
@jorgeorpinel jorgeorpinel requested a review from efiop April 7, 2020 07:26
@efiop efiop merged commit f325921 into master Apr 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the 2020-04-06 branch April 7, 2020 09:50
@efiop
Copy link
Contributor

efiop commented Apr 7, 2020

Thanks @jorgeorpinel ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants