metrics: rework metrics implementation #3658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
3572
branch
2 times, most recently
from
a3fe66f to
8ab3506
Compare
Contributor
Author
|
Need to use custom loader for yaml for metrics and params to load float as Decimal. That way it will be much nicer looking and we won't have to bother with precision. Will provide a separate PR. |
efiop
force-pushed
the
3572
branch
5 times, most recently
from
d374347 to
69aa10b
Compare
Dropping support for all types except json and yaml. No more xpath support. Fixes treeverse#3572
efiop
changed the title
2 tasks
shcheklein
reviewed
Apr 22, 2020
| ) | ||
| metrics_show_parser.add_argument( | ||
| "-x", "--xpath", help="json/yaml path.", metavar="<path>", | ||
| ) |
Contributor
There was a problem hiding this comment.
I thought we wanted to keep for metrics show (may be diff as well)?
Contributor
Author
There was a problem hiding this comment.
Not in the same shape. As a filter - maybe, but later.
Contributor
|
Do we flatten the table in metrics show as we do for metrics diff now? |
Contributor
Author
Not like in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping support for all types except json and yaml. No more xpath
support.
Fixes #3572
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
@dmpetrov agreed to provide docs PR for this. 🙏
Thank you for the contribution - we'll try to review it as soon as possible. 🙏