Skip to content

dvc: implement params support for pipeline file #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2020
Merged

dvc: implement params support for pipeline file #3694

merged 4 commits into from
Apr 29, 2020

Conversation

@skshetry
Copy link
Collaborator

@skshetry skshetry commented Apr 28, 2020 •
edited
Loading

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Continuing from #3676
Part of #1871

This PR implements params support for pipeline file.

The pipeline file will have following format:

    params:
    -  process.thresh
    - process.bow
    - params2.yaml:  # notice the format for custom params file
      - lr
      - train.epochs

@skshetry skshetry self-assigned this Apr 28, 2020
@skshetry skshetry changed the title [WIP] dvc: implement params support for pipeline file dvc: implement params support for pipeline file Apr 29, 2020
@skshetry skshetry requested review from efiop, pared and pmrowla April 29, 2020 07:32
@efiop efiop merged commit 7edee84 into treeverse:master Apr 29, 2020
@skshetry skshetry deleted the support-params branch April 29, 2020 11:45
@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pared pared Awaiting requested review from pared

@pmrowla pmrowla Awaiting requested review from pmrowla

1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skshetry skshetry

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skshetry @efiop