Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented May 8, 2020

These messages all correpond to expected behaviour, so there is no need
to polute the output with unnecessary warnings.

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop efiop requested a review from skshetry May 8, 2020 00:06
These messages all correpond to expected behaviour, so there is no need
to polute the output with unnecessary warnings.
@efiop efiop force-pushed the hide_warnings branch from ff90c25 to 76f6f08 Compare May 8, 2020 00:08
@skshetry
Copy link
Collaborator

skshetry commented May 8, 2020

These messages all correpond to expected behaviour

@efiop, how will the users know why dvc is re-running a given stage?

@efiop
Copy link
Contributor Author

efiop commented May 8, 2020

@skshetry By running dvc status beforehand. No need to bombard them with warnings. These warnings were introduced by a user back when status was lacking some functionality.

@efiop efiop merged commit 2a16b02 into treeverse:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants