-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[WIP] dependency: fine grained (user cmd filter) #4363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dvc/utils/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if there are aspects of stage.run.cmd_run which should be used here
dvc/utils/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is required - maybe automatically handled elsewhere (i.e. entire tmpdir deleted before exit)
a469eb4 to
aa4cd31
Compare
dvc/dependency/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe assert not required (should be handled by schema)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other CLI commands can create/load dependencies, skipping the schema. Good to have an assert.
TODO: insert cmd into dvc.lock
|
Closing for now, we'll get back after dep/out refactor to properly accommodate this. |
dvc.yamldvc.lockdvc.yaml:stages.<stage>.deps.[].<path>.cmd)dvc.lockdvc run -d "utils.py:extract_function.py --name check_db"Note that this implementation
PARAM_FILTER = "cmd"pathas a positional argument to the user-definedcmdcmdoutputcmd: catschema:
testing: