Remove version restriction from networkx #5110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Mergifyio backport 1.11 |
Contributor
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
(cherry picked from commit 84a3a59)
Contributor
|
Command
|
efiop
pushed a commit
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Some libraries are starting to use networkx 2.5, which is the latest version released on August.
DVC however depends on networkx < 2.5, which causes some incompatibilities. This restriction was likely to prevent future breaking changes, since it was added before the release of 2.5 (#4219).
I've removed the version restriction, ran all tests and everything worked ok.