Skip to content

webhdfs: migrate to fsspec - #6662

Merged
efiop merged 2 commits into
treeverse:masterfrom
isidentical:migrate-webhdfs
Oct 7, 2021
Merged

webhdfs: migrate to fsspec#6662
efiop merged 2 commits into
treeverse:masterfrom
isidentical:migrate-webhdfs

Conversation

@isidentical

Copy link
Copy Markdown
Contributor

Resolves #6583, awaiting an fsspec release.

@isidentical isidentical added the fs: webhdfs Related to the WebHDFS filesystem label Sep 21, 2021
@isidentical
isidentical requested a review from efiop September 21, 2021 13:32
Comment thread dvc/fs/webhdfs.py Outdated
Comment on lines 41 to 43

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: discussed that we might just drop hdfscli config, since we are no longer using it as a backend.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isidentical Wdyt, removing it or not?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can.

Comment thread dvc/fs/webhdfs.py Outdated
Comment thread tests/remotes/webhdfs.py Outdated
@efiop

efiop commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

@Mergifyio rebase

@mergify

mergify Bot commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Command rebase: success

Branch has been successfully rebased

Comment thread dvc/fs/webhdfs.py Outdated
Comment on lines 41 to 43

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isidentical Wdyt, removing it or not?

@isidentical
isidentical marked this pull request as ready for review October 7, 2021 08:44
@isidentical
isidentical requested a review from a team as a code owner October 7, 2021 08:44
@isidentical

Copy link
Copy Markdown
Contributor Author

It seems like the docker is randomly failing on some runs with timeouts. I've increased the timeout from 30 to 60 seconds, hopefully that will solve it. (In the past we were mocking hdfs-cli's InsecureClient, so we weren't using the real hdfs server).

Comment thread dvc/fs/webhdfs.py Outdated
Comment thread dvc/fs/webhdfs.py Outdated
Comment thread tests/remotes/webhdfs.py Outdated
Comment thread tests/remotes/webhdfs.py Outdated
@efiop
efiop merged commit 4f3b28e into treeverse:master Oct 7, 2021
skshetry added a commit to endremborza/dvc that referenced this pull request Oct 8, 2021
* master: (47 commits)
  make dependabot updates work (treeverse#6760)
  move defaults to the class level (treeverse#6762)
  build(deps): Bump dvclive from 0.3.0 to 0.4.0 (treeverse#6753)
  move requirements to setup.cfg (treeverse#6758)
  gha: cancel previous workflows (treeverse#6756)
  pyinstaller: hooks: remove webhdfs
  webhdfs: migrate to fsspec (treeverse#6662)
  gha: benchmarks: fix pytest flags (treeverse#6749)
  hdfs: migrate to fsspec (treeverse#6604)
  Pin dvclive to 0.3.0
  command: Should not consume 'print' to output default remote info (treeverse#6650)
  command: output prettify json in tty (treeverse#6743)
  gha: run benchmarks on PRs (treeverse#6733)
  Run on Python3.10 (treeverse#6745)
  Fix dvclive running subdir (treeverse#6740)
  exp init: only ask for that are not provided in an interactive mode (treeverse#6739)
  move exp init logic to dvc.repo.experiments.init (treeverse#6738)
  build(deps): Bump jaraco-windows from 5.6.0 to 5.7.0 (treeverse#6735)
  build(deps): Bump pytest-cov from 2.12.1 to 3.0.0 (treeverse#6736)
  Bump typing_extensions to >=3.7.4 (treeverse#6731) (treeverse#6732)
  ...
@efiop efiop added the enhancement Enhances DVC label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances DVC fs: webhdfs Related to the WebHDFS filesystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webhdfs: migrate to fsspec

4 participants