cli: add short alias for --show-{csv,json,md} - #6711
Merged
Conversation
As `--csv`/`--json`/`--md`
skshetry
added
enhancement
skshetry
commented
Sep 30, 2021
| default=False, | ||
| ) | ||
| diff_parser.add_argument( | ||
| "--md", |
Collaborator
Author
There was a problem hiding this comment.
I always try to use -md (single dash) on these abbreviations, so I am not a fan of this, but --markdown is too long. And --md is what we use in CML as well.
dberenbaum
approved these changes
Sep 30, 2021
dberenbaum
left a comment
dberenbaum
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Are you planning a corresponding docs PR?
Collaborator
Author
yes, I'll submit one tomorrow. |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
--csv/--json/--mdFixes #6488. My plan is to replace options from docs soon and remove these options in 3.0 (though we could keep it, they won't cause any issues).
--csv/--json/--mdflags dvc.org#2877Documentation can be done after we merge this PR, as this is just an alias.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏