exp init: Replace live section with metrics and plots. - #7603
Merged
Conversation
daavoo
requested review from
dberenbaum,
efiop and
skshetry
and removed request for
efiop
April 20, 2022 07:46
daavoo
commented
Apr 20, 2022
| # TODO: discuss: | ||
| # IMO, specifying `live` should not create checkpoint output | ||
| # unless type="dl" is passed | ||
| "outs": ["models"], |
Contributor
Author
There was a problem hiding this comment.
@dberenbaum / @skshetry I might have missed the discussion about this behavior.
Enabling checkpoints makes sense with type="dl", but passing live should not mean that checkpoints are also enabled.
I have changed the previous behavior in order to decouple live from checkpoints. Checkpoints are only enabled with type="dl".
Collaborator
There was a problem hiding this comment.
It was introduced in #6716. I don't remember exactly why it was done this way, but probably it was done to unify with interactive mode (even with --type=dl, users can omit live).
It makes sense to do that anyway on --type="dl".
skshetry
reviewed
Apr 20, 2022
daavoo
force-pushed
the
exp-init-live
branch
3 times, most recently
from
April 20, 2022 09:08
e37298d to
51039a6
Compare
skshetry
reviewed
Apr 20, 2022
skshetry
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7534