Table data in redux #2112
Table data in redux #2112
Conversation
sroy3
requested review from
julieg18,
mattseddon,
rogermparent and
wolmir
as code owners
| ...state, | ||
| ...action.payload, | ||
| hasData: true | ||
| } |
There was a problem hiding this comment.
This is pretty much the same as it was before. An improvement here would be to go through previous columns, rows and objects to change the reference of only what changed. I will do that as a follow up.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| width: DEFAULT_COLUMN_WIDTH | ||
| } | ||
|
|
||
| export const ExperimentsTable: React.FC = () => { |
There was a problem hiding this comment.
Function ExperimentsTable has 73 lines of code (exceeds 30 allowed). Consider refactoring.
| } | ||
|
|
||
| export const ExperimentsTable: React.FC = () => { | ||
| const { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
julieg18
left a comment
julieg18
left a comment
There was a problem hiding this comment.
Great work! Things look more readable with less props being passed around :)
mattseddon
left a comment
mattseddon
left a comment
There was a problem hiding this comment.
[Q] How does performance compare? Looks good to go otherwise.
I'm not seeing any difference. It's pretty much just a drop in replacement since the whole thing changes when the data changes. Like I said I'll follow up to try to limit the changes to only what changes. That could help with really big project, but that is not something we will notice otherwise. |
|
Code Climate has analyzed commit ddd0779 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.2% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
3 participants
Closes #2103