docs(pool,convert,upstream,server): task-local CONTRACT.md + burst-test lease hygiene - #357
Merged
Conversation
…st lease hygiene Four package contracts (purpose, public API, allowed/forbidden deps, critical invariants, protecting tests, safe modification patterns) so an agent working one package no longer needs the whole-repo mental model: pool, convert, upstream, server. All claims grounded in the current code (imports verified by grep, invariants cite exact files). Also releases the winning lease in the two RPM burst-atomicity tests instead of stranding the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts
Four task-local package contracts (purpose, public API, allowed/forbidden dependencies, critical invariants, protecting tests, safe modification patterns) so an agent working one package no longer needs the whole-repo mental model. AGENTS.md untouched by design.
pool/CONTRACT.md: failover bucket precedence, lease contract, swap-safety, RPM/RPD semantics, bridgeMu discipline, maturity posture.convert/CONTRACT.md: purity rule + import boundary test, end_turn parity, schema caps, plural-dialect extraction.upstream/CONTRACT.md: anti-ban header contract, TTFB-only timeout, transient-retry rules, turn_spend terminal.server/CONTRACT.md: protocol split, retry-once matrix, envelope rules, dashboard security gates, parallel-work hazard note.All claims grounded in current code (imports grepped, invariants cite files).
Test hygiene
Releases the winning lease in
TestAcquireRPMAdmitBurstIsAtomic/TestBridgeRPMAdmitBurstIsAtomicinstead of stranding the run.Verification
go vetclean;gofmtclean (my files).backend/internal/archtest/(parallel session, untracked) flags its own formatting — not mine, not in this PR.