Populate declaration-site locations on file-scope decl carriers - #100
Merged
Conversation
The protowire.schema.v1 decl carriers (FileAnnotationDecls, FileFunctions, FileTypeDecls) all carry a SourceLocation field, but none of the three builders populated it — only annotation use sites got locations. Anchor each declaration's location at its name token, matching the use-site convention. Fixes #99
trendvidia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99.
The
protowire.schema.v1file-scope declaration carriers (FileAnnotationDecls50401,FileFunctions50402,FileTypeDecls50403) all define alocationfield, but none of the three builders infdp/annotations.gopopulated it — only annotation use sites did, vialocationOf(u.AST().At()).Each builder now sets
Locationfrom the declaration's name token (AST().Name()), matching the use-site convention of anchoring at the name.locationOfalready returns nil for zero tokens, so synthesized decls with no source form are unaffected.Consumers unblocked:
New
TestAnnotationEmissionDeclLocationsasserts file/line/column for all three carrier kinds. No golden churn — existing goldens don't serialize the decl carriers' location field.