spec: pin project-level engine-config format (RFC-001 §9.4) - #95
Merged
Merged
Conversation
Resolves spec issue #11 (GH #60). - proto/schema/config/v1/config.proto: EngineConfig message. Config is a textproto file (protowire.config.textproto at project root), not a schema-less .proto carrying file options — keeps the no-JSON/YAML principle without burning carrier extension numbers or leaking build config into FileDescriptorSet artifacts. - Discovery: upward walk, nearest config wins, no merging (go.mod model). - Precedence: per-setting CLI flags > --config > PROTOWIRE_CONFIG (file pointer only) > discovered file > defaults (cel, lenient, collect-all). Unknown engine names are startup errors, never fallbacks. - default_mode reuses protowire.schema.v1.ExecutionMode from report.proto; field 6 earmarked for the #62 recursion-depth knob. - New RFC-001 §9.4; §13 row 2 resolved; CHANGELOG updated. - testdata/schema-extensions/08_engine_config.textproto: golden config, verified with stock protoc (parse + --encode/--decode round-trip).
This was referenced Jul 16, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60 (spec item #11). Stacked on #94 (
config.protoimportsreport.protoforExecutionMode); retarget/merge after #94.What
proto/schema/config/v1/config.proto(new):EngineConfig—engine(registered string id),function_libraries,catalog_libraries,strict_validation,default_mode(reusesprotowire.schema.v1.ExecutionMode). Build-time artifact loaded fromprotowire.config.textprotoat the project root; never embedded in descriptors; allocates no extension numbers.testdata/schema-extensions/08_engine_config.textproto: golden config exercising every field.Design decisions (vs. the issue sketch)
.proto-with-options file. The sketched options file would burn FileOptions extension numbers on non-carrier config, create a schema-less.protothat glob-driven builds sweep intoFileDescriptorSets, and force values through the option-value grammar. Textproto is still proto (no-JSON/YAML holds) and gets a real typed message."cel","starlark","go"), not an enum — third-party engines need no spec churn; unknown names are startup errors, never fallbacks.go.modmodel) — merge semantics would reintroduce implicit inheritance.--config <path>>PROTOWIRE_CONFIG(file pointer only, no per-setting env vars) > discovered file > defaults (cel, lenient, collect-all).reserved) for the Recursive message validation depth limits #62 recursion-depth knob.The issue's second acceptance box (reference Go loader in
protocompile) is M1 follow-up implementation work, tracked in the issue comment rather than blocking the spec decision.Verification
config.protoparses with stock protoc; the golden fixture round-trips throughprotoc --encode/--decode(105-byte binary).