fix: refresh header sync indicator immediately after committing - #108
Merged
Conversation
Committing from the Review tab refreshed the diff viewer's own state but left the workspace-status query untouched, so the header's ↑N sync indicator stayed stale until something else happened to refetch it -- in practice, navigating to another workspace and back. For a workspace level with its remote the control is hidden entirely at ↑0, so the indicator did not appear at all after the commit. Invalidate the workspace-status and workspace-statuses queries alongside the existing post-commit refreshes so the header and sidebar pick up the new ahead count on their own. Adds an integration test (fails without the fix) and a screenshot spec capturing the header before and after the commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committing from the Review tab refreshed the diff viewer's own state but
left the workspace-status query untouched, so the header's ↑N sync
indicator stayed stale until something else happened to refetch it --
in practice, navigating to another workspace and back. For a workspace
level with its remote the control is hidden entirely at ↑0, so the
indicator did not appear at all after the commit.
Invalidate the workspace-status and workspace-statuses queries alongside
the existing post-commit refreshes so the header and sidebar pick up the
new ahead count on their own.
Adds an integration test (fails without the fix) and a screenshot spec
capturing the header before and after the commit.