[TRI-689] Login through magic link not working in Safari when running on localhost:3030

[ericallam]

Safari version: Version 16.4.1 (17615.1.26.101.10, 17615)

To recreate, make sure you DON'T have the RESEND_API_KEY env var set, so the magic link is printed to the terminal instead of actually sent as an email (I can't recreate the problem when the magic link is sent through the email).

After navigating to the magic link (in Safari) you will get redirected back to the magic link page, instead of into the dashboard.

I'm thinking this might have something to do with the the cookie session storage (which you can find here: https://github.com/triggerdotdev/trigger.dev/blob/bca0df2692a9255d79a3858e8bb091cdfa883632/apps/webapp/app/services/sessionStorage.server.ts) but I'm not exactly sure what is causing it

_TRI-689

[ericallam]

/bounty $50

[algora-pbc]

💎 $50 bounty created by ericallam
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #186 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to triggerdotdev/trigger.dev!

[imrishabh18]

/attempt #186

[imrishabh18]

Hey @ericallam, I have tried couple of times to recreate the issue, but the magic link in my terminal is redirecting it to the Dashboard. Can you share some more steps please or am I missing something?

P.S. - I am a beginner to open source contributions, would love to help and contribute.

[SSHari]

@ericallam It looks like this might be the result of the cookie being sent with the secure flag. What's odd is that MDN mentions that this shouldn't be a problem for localhost, but it might be a bug with Safari.

I changed the NODE_ENV in the start script as follows so it runs in development mode:

Changing the environment toggles the secure flag here:

Running the app this way removes the Secure flag from the cookies that are returned from the server. I was able to get things working after making this change.

Here's an example of the before/after of a returned cookie:

Before

After

I guess the question is are you only seeing this locally, or are you also experiencing this in a deployed version of the application?

[ericallam]

Oh interesting, I actually think we should probably remove setting the NODE_ENV like that so we can run start with either NODE_ENV=production and NODE_ENV=development, although I wonder if the NODE_ENV=production line in the Dockerfile will override that.

[ericallam]

Just to note, you can build the Docker image locally using the following command:

docker build -f ./docker/Dockerfile -t <tag name here> .

[ericallam]

@imrishabh18 have you seen the above comments?

[rishi-raj-jain]

@ericallam Can I work on this one?