Skip to content

Conversation

@LeoKaynan
Copy link
Contributor

  • Move S3 credentials from secrets.objectStore to s3.auth
  • Update external PostgreSQL config to use databaseUrl/directUrl approach
  • Add existingSecret support for PostgreSQL with secretKeys
  • Add TLS configuration for external Redis
  • Add existingSecret support for Redis, ClickHouse and S3
  • Add complete external S3 configuration example
  • Improve secure credential management documentation

These changes align the production example file with the current values.yaml structure, making it easier to configure external services with better support for secret management.

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing


Changelog


Screenshots

💯

- Move S3 credentials from secrets.objectStore to s3.auth
- Update external PostgreSQL config to use databaseUrl/directUrl approach
- Add existingSecret support for PostgreSQL with secretKeys
- Add TLS configuration for external Redis
- Add existingSecret support for Redis, ClickHouse and S3
- Add complete external S3 configuration example
- Improve secure credential management documentation

These changes align the production example file with the current values.yaml
structure, making it easier to configure external services with better
support for secret management.
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: a284b4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

  • Updated Helm values-production-example.yaml.
  • Removed secrets.objectStore credentials.
  • Added webapp S3 credentials under s3.auth (accessKeyId, secretAccessKey).
  • Replaced PostgreSQL external configuration with a connection block using a databaseUrl template and related fields.
  • Expanded commented guidance for Redis, ClickHouse, and S3 to illustrate secret-based credential patterns and potential secret references, without enabling them.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description outlines the specific configuration updates and includes a completed checklist, but it omits the required “Closes #” reference and lacks content in the Testing, Changelog, and Screenshots sections, leaving critical template items unfilled. Please add the issue closure line (e.g., “Closes #1234”) at the top of the description and provide details under Testing, Changelog, and Screenshots to fully satisfy the repository’s template requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title clearly communicates that this Helm chore aligns the example production values file with values.yaml, accurately reflecting the PR’s core purpose of synchronizing configuration structures.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeoKaynan LeoKaynan changed the title fix(helm): align values-production-example.yaml with values.yaml chore(helm): align values-production-example.yaml with values.yaml Oct 14, 2025
Copy link
Collaborator

@nicktrn nicktrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicktrn nicktrn merged commit 63b6fc9 into triggerdotdev:main Oct 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants