Conversation
Co-Authored-By: nick <55853254+nicktrn@users.noreply.github.com>
|
🧭 Helm Chart Prerelease PublishedVersion: Install: helm upgrade --install trigger \
oci://ghcr.io/triggerdotdev/charts/trigger \
--version "4.4.4-pr3432.19ff45d"
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: nick <55853254+nicktrn@users.noreply.github.com>
7f33ffb to
19ff45d
Compare
|
ready |
✅ Checklist
Testing
Chart lint / template
helm dependency build+helm lintpass cleanly.helm templaterenders successfully; the only diff vs. the 4.0.6 render is the chart labels andtriggerdotdev/trigger.dev:v4.4.4/triggerdotdev/supervisor:v4.4.4image refs — no structural differences.Fresh install on a local kind cluster
Ran
hosting/k8s/setup-kind.sh→helm install trigger ./hosting/k8s/helm -n triggeron a single-node kind cluster (with a lightresourcesoverride so everything fits on 2 CPU / 8 GB).webapp(2/2),supervisor,postgres,redis,clickhouse,electric,minio,minio-console.RUN_REPLICATION_ENABLED=1established the logical-replication slottask_runs_to_clickhouse_v1against the deployed Postgres automatically.token-syncersidecar), WS connected to platform, failed-pod handler + pod-cleaner informers healthy.helm testsuites pass:test-clickhouse,test-electric,test-postgres,test-redis,test-s3,test-webapp(webapp/healthcheckgreen).App-level compatibility audit (v4.0.4 → v4.4.4, 532 commits, 272 touching webapp/supervisor)
apps/webapp/app/env.server.ts): every newly added variable is either.optional()or has a default. OnlyCLICKHOUSE_URLis unconditionally required, and the chart already wires it viainclude "trigger-v4.clickhouse.url". Cross-checked in the reverse direction: no env var the chart currently sets has been removed or renamed (APP_LOG_LEVEL/DATABASE_HOSTare still read viaprocess.env, andCLICKHOUSE_PASSWORDis shell-substituted intoCLICKHOUSE_URLwhen using an external-secret ClickHouse).apps/supervisor/src/env.ts): all new settings have defaults. The new conditional requirements in thesuperRefine(TRIGGER_METADATA_URL,TRIGGER_WORKLOAD_API_DOMAIN) only trigger whenCOMPUTE_SNAPSHOTS_ENABLED=true, which defaults off;TRIGGER_WORKLOAD_API_DOMAINis already set by the chart unconditionally.packages/core/src/v3/runEngineWorker/supervisor/+apps/webapp/app/routes/engine.v1.worker-actions.*): only additive changes. The new ComputeWorkloadManager path is gated by thehasComputeAccessfeature flag andCOMPUTE_SNAPSHOTS_ENABLED, both off by default.fix(run-queue): prevent concurrency keys from bloating master queue shards): commit message explicitly calls out "Old-format entries drain naturally during rollout — no migration step needed, single deploy." No keyspace migration required.docker/scripts/entrypoint.sh(no manual step).db:migrate:deployin the entrypoint. Includes one FK-drop migration (metadata-only, fast) and a covering index createdCONCURRENTLY(non-blocking).1.2.4in the existing chartvalues.yaml; the webapp's Electric client was upgraded in-step.OBJECT_STORE_*env vars remain optional with unchanged names.OBJECT_STORE_DEFAULT_PROTOCOLis an optional opt-in for zero-downtime migrations to new providers. Users who were working on v4.0.4 continue to work unchanged on v4.4.4.Upgrade notes
None required. No manual migration, no breaking values/env-var change, and no new required configuration for existing deployments. First webapp rollout after upgrade will spend extra time applying ~30 Prisma + 22 ClickHouse migrations on startup; beyond the longer init window there's no operator action to take.
Changelog
Bump the Helm chart
appVersionandversionfromv4.0.4/4.0.6tov4.4.4/4.4.4so users pull the latest released webapp and supervisor images by default, with chartversionkept in sync withappVersion. Novalues.yamlchanges are required — all new env vars introduced between 4.0.4 and 4.4.4 are optional or covered by existing chart defaults, and ClickHouse remains a required dependency wired end-to-end.Link to Devin session: https://app.devin.ai/sessions/742fb351b3df4811b15ebaf1963669f4