Skip to content

chore: bump node to latest patch release#3802

Merged
nicktrn merged 1 commit into
mainfrom
chore/bump-node-20-20-2
Jun 2, 2026
Merged

chore: bump node to latest patch release#3802
nicktrn merged 1 commit into
mainfrom
chore/bump-node-20-20-2

Conversation

@nicktrn
Copy link
Copy Markdown
Collaborator

@nicktrn nicktrn commented Jun 2, 2026

Bumps Node to the latest 20.x patch.

@nicktrn nicktrn self-assigned this Jun 2, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

⚠️ No Changeset found

Latest commit: 14c767b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ Incomplete version bump: references/prisma-7/.nvmrc still at 20.20.0 (references/prisma-7/.nvmrc:1)

This PR is a mechanical transformation bumping Node.js from 20.20.0 to 20.20.2 across the repo. However, references/prisma-7/.nvmrc still contains 20.20.0. Git history (936bddf19) shows this file was previously updated as part of the Node 20.20.0 bump, confirming it's meant to track the root .nvmrc version — it's not independently pinned like references/ai-chat/.nvmrc (which uses v22) or apps/supervisor/.nvmrc (which uses v22.12.0).

View 2 additional findings in Devin Review.

Open in Devin Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f252e03c-2c01-4932-8c2a-06fae0e11635

📥 Commits

Reviewing files that changed from the base of the PR and between 4c4ed22 and 14c767b.

📒 Files selected for processing (15)
  • .github/workflows/changesets-pr.yml
  • .github/workflows/claude.yml
  • .github/workflows/e2e-webapp-auth-full.yml
  • .github/workflows/e2e-webapp.yml
  • .github/workflows/e2e.yml
  • .github/workflows/release.yml
  • .github/workflows/sdk-compat.yml
  • .github/workflows/typecheck.yml
  • .github/workflows/unit-tests-internal.yml
  • .github/workflows/unit-tests-packages.yml
  • .github/workflows/unit-tests-webapp.yml
  • .nvmrc
  • AGENTS.md
  • CONTRIBUTING.md
  • docker/Dockerfile
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (5, 8)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (2, 8)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (1, 8)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (7, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 8)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (8, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 8)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 8)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (6, 8)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (3, 8)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: internal / 🧪 Unit Tests: Internal (4, 8)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 8)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (1, 1)
  • GitHub Check: 🛡️ E2E Auth Tests (full)
🧰 Additional context used
📓 Path-based instructions (1)
**/{Dockerfile,docker-compose*,*.dockerfile}

📄 CodeRabbit inference engine (CLAUDE.md)

When updating Docker image references, always use multiplatform/index digests, not architecture-specific digests. Architecture-specific digests cause CI failures on different build environments.

Files:

  • docker/Dockerfile
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: triggerdotdev/trigger.dev

Timestamp: 2026-06-02T09:22:23.955Z
Learning: Use pnpm as the package manager with version 10.33.2 or higher
Learnt from: CR
Repo: triggerdotdev/trigger.dev

Timestamp: 2026-06-02T09:22:23.955Z
Learning: Require Node.js version 20.20.2 or higher
Learnt from: CR
Repo: triggerdotdev/trigger.dev

Timestamp: 2026-06-02T09:22:23.955Z
Learning: Format code using Prettier before committing
Learnt from: CR
Repo: triggerdotdev/trigger.dev

Timestamp: 2026-06-02T09:22:23.955Z
Learning: Follow existing project conventions for code organization and naming
Learnt from: CR
Repo: triggerdotdev/trigger.dev

Timestamp: 2026-06-02T09:22:23.955Z
Learning: Do not commit directly to the `main` branch; all changes must be made in a separate branch and go through a pull request
📚 Learning: 2026-04-13T21:43:58.707Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/app/services/taskIdentifierRegistry.server.ts:49-58
Timestamp: 2026-04-13T21:43:58.707Z
Learning: In `apps/webapp/app/services/taskIdentifierRegistry.server.ts` (and closely related task registry/sync code in this module), an empty deployment (zero tasks) is not a realistic/expected scenario. Do not flag or require special handling or fallback logic for missing empty-task cases in this registry/sync flow.

Applied to files:

  • .nvmrc
📚 Learning: 2026-04-23T13:26:27.529Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3430
File: apps/webapp/app/presenters/v3/RunStreamPresenter.server.ts:0-0
Timestamp: 2026-04-23T13:26:27.529Z
Learning: In this codebase’s SSE implementation (notably `apps/webapp/app/utils/sse.ts` and its SSE callers such as `apps/webapp/app/presenters/v3/RunStreamPresenter.server.ts`), do not treat `.abort()` vs `.abort("<reason string>")` differences as a heap retention/memory leak issue on Node 20. Heap deltas are identical once `AbortSignal.any` is not involved; the investigated SSE memory leak root cause was `AbortSignal.any` (via FinalizationRegistry behavior on abort). When reviewing, focus on whether `AbortSignal.any` (or similar signal-combining/finalization patterns) is used in the SSE abort path rather than the presence/contents of the abort reason string. Named abort-reason sentinel constants (e.g., `ABORT_REASON_*`) are for readability/style only, not correctness.

Applied to files:

  • .nvmrc
📚 Learning: 2026-04-30T21:28:35.705Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3473
File: internal-packages/database/prisma/schema.prisma:59-60
Timestamp: 2026-04-30T21:28:35.705Z
Learning: In this repo, session-duration lower-bound validation is intentionally enforced only at the app layer (via `isAllowedSessionDuration` and `SESSION_DURATION_OPTIONS`), where the minimum allowed value is 300 seconds (5 minutes). `User.sessionDuration` is `Int` (non-nullable) and `Organization.maxSessionDuration` is `Int?` (nullable). There are currently no DB-level `CHECK` constraints for these fields anywhere in the migrations, so future reviews should not flag the absence of DB `CHECK` constraints on these session-duration fields—focus validation on the app-layer logic instead.

Applied to files:

  • .nvmrc
📚 Learning: 2026-05-12T06:43:09.116Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3558
File: internal-packages/run-engine/src/run-queue/index.ts:420-424
Timestamp: 2026-05-12T06:43:09.116Z
Learning: In internal-packages/run-engine/src/run-queue/index.ts, the RunQueue “read-path” counter/concurrency methods (e.g., lengthOfQueue/lengthOfQueues/currentConcurrencyOfQueues) intentionally “fail open” on transient Redis pipeline result errors. If you see pipeline result errors (e.g., baseErr/ctrErr) being coerced to 0 (treating Redis command errors the same as missing keys) rather than surfaced/thrown, do not flag it as a bug and do not suggest propagating those errors in future reviews.

Applied to files:

  • .nvmrc
📚 Learning: 2026-05-19T21:04:49.990Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3671
File: packages/trigger-sdk/src/v3/ai.ts:724-769
Timestamp: 2026-05-19T21:04:49.990Z
Learning: In packages/trigger-sdk/src/v3/ai.ts, when reviewing recovery/replay of turns, do NOT flag “lost metadata on recovered turns” if the recovered turns are reconstructed via the recovery boot queue that maps metadata by message.id (using replaySessionInTail’s {message, metadata, seqNum} per session.in record). If a message has no matching session.in record (e.g., hook-synthesized messages), the code intentionally falls back to the current boot payload’s metadata—this fallback is expected behavior.

Applied to files:

  • .nvmrc
🔇 Additional comments (15)
AGENTS.md (1)

16-16: LGTM!

CONTRIBUTING.md (1)

32-32: LGTM!

Also applies to: 52-52

.github/workflows/changesets-pr.yml (1)

39-39: LGTM!

.github/workflows/claude.yml (1)

42-42: LGTM!

.github/workflows/e2e-webapp-auth-full.yml (1)

88-88: LGTM!

.github/workflows/e2e-webapp.yml (1)

62-62: LGTM!

.github/workflows/e2e.yml (1)

40-40: LGTM!

.github/workflows/release.yml (1)

93-93: LGTM!

Also applies to: 291-291

.github/workflows/sdk-compat.yml (1)

73-73: LGTM!

Also applies to: 115-115, 161-161

.github/workflows/typecheck.yml (1)

28-28: LGTM!

.github/workflows/unit-tests-internal.yml (1)

67-67: LGTM!

Also applies to: 137-137

.github/workflows/unit-tests-packages.yml (1)

67-67: LGTM!

Also applies to: 137-137

.github/workflows/unit-tests-webapp.yml (1)

67-67: LGTM!

Also applies to: 145-145

.nvmrc (1)

1-1: LGTM!

docker/Dockerfile (1)

1-1: LGTM!


Walkthrough

This pull request upgrades the Node.js runtime version from 20.20.0 to 20.20.2 across the entire project infrastructure. The change is applied consistently to 11 GitHub Actions workflows (covering CI/CD jobs for changesets, e2e tests, unit tests, SDK compatibility, typecheck, and release processes), the local development version manager configuration (.nvmrc), the Docker build image digest, and relevant documentation files (AGENTS.md and CONTRIBUTING.md). No logic, job structure, or workflow behavior is modified; only the pinned runtime version is incremented.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and does not follow the required template structure, missing testing steps, changelog details, and verification checklist. Complete the PR description template by adding testing procedures, detailed changelog entry, and confirming all checklist items were followed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating Node.js to the latest patch release in the 20.x series.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-node-20-20-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nicktrn nicktrn enabled auto-merge (squash) June 2, 2026 09:50
@nicktrn nicktrn merged commit 11631c1 into main Jun 2, 2026
50 checks passed
@nicktrn nicktrn deleted the chore/bump-node-20-20-2 branch June 2, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants