chore(docker): tidy dev postgres + clickhouse images#3859
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2026-06-02T21:20:43.541ZApplied to files:
🪛 Checkov (3.2.530)internal-packages/clickhouse/Dockerfile[medium] 10-11: Basic Auth Credentials (CKV_SECRET_4) 🔇 Additional comments (1)
WalkthroughThis PR updates two Dockerfiles: the PostgreSQL Dockerfile adds --no-install-recommends to the apt-get install of postgresql-14-partman. The ClickHouse Dockerfile pins the Go base image and the goose CLI to specific versions and sets the container runtime user to nobody so migrations run as a non-root user. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
37eb4d8 to
e6f44f7
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/plugins
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
Two small hygiene tweaks to dev-only images:
docker/Dockerfile.postgres: add--no-install-recommendsto the partman install (leaner image, skips unneeded recommended packages).internal-packages/clickhouse/Dockerfile: run the migration helper as a non-root user.Both are local-dev images (the
pnpm run dockerstack) - no impact on the published webapp image, prod, or self-hosting.