Skip to content

fix(webapp): update task filter icons and the scheduled run icon#4065

Merged
samejr merged 2 commits into
mainfrom
samejr/update-task-icons
Jun 28, 2026
Merged

fix(webapp): update task filter icons and the scheduled run icon#4065
samejr merged 2 commits into
mainfrom
samejr/update-task-icons

Conversation

@samejr

@samejr samejr commented Jun 28, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the Tasks icon on the Runs, Logs, Errors, and metrics pages (and the task-derived queue indicators) to use the correct "T" tasks icon, and shows a clock icon for scheduled runs in the run inspector header.

Before

CleanShot 2026-06-28 at 21 39 57@2x

After

CleanShot 2026-06-28 at 21 38 59@2x

Use the all-tasks icon for the task and task-type filter buttons on the
Runs, Logs, Errors, and metrics pages and for task-derived queue
indicators, and show a clock icon for scheduled runs in the run
inspector header.
@changeset-bot

changeset-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8977d6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Two sets of changes are made. First, across several filter and queue components (LogsTaskFilter, QueuesFilter, QueueName, RunFilters, TaskRunsTable), the icon used for task-type items is changed from TaskIcon/TaskIconSmall to TasksIcon. Second, a new isScheduled boolean (derived from taskKind === "SCHEDULED") is computed in SpanPresenter.getRun and buildSyntheticSpanRun and included in the returned run objects. The run inspector's RunBody header then uses this flag to select a clock icon and apply text-schedules color styling for scheduled runs.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR includes a summary and screenshots, but it is missing the required issue reference, checklist, testing steps, and changelog sections. Add the missing template sections: Closes #issue, checklist, testing details, and a short changelog entry.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main UI icon update across task-related filters and scheduled runs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch samejr/update-task-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 new potential issues.

Open in Devin Review

@samejr samejr merged commit 9f29eb2 into main Jun 28, 2026
31 checks passed
@samejr samejr deleted the samejr/update-task-icons branch June 28, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants