fix(core,cli): retain idempotency key metadata beyond 1000 keys per run#4094
Open
matt-aitken wants to merge 1 commit into
Open
fix(core,cli): retain idempotency key metadata beyond 1000 keys per run#4094matt-aitken wants to merge 1 commit into
matt-aitken wants to merge 1 commit into
Conversation
The in-process catalog that maps an idempotency key's hash back to its original key and scope was a fixed-size LRU capped at 1000 entries. A run that created more than 1000 idempotency keys silently evicted the earliest mappings, so the SDK sent no idempotencyKeyOptions when triggering. Those runs lost their key/scope: ctx.run.idempotencyKey showed only the hash and the dashboard/analytics key and scope came back empty. Replace the LRU with an unbounded in-memory catalog so every key created in a run keeps its metadata regardless of count, and clear the catalog at each run boundary (via resetExecutionEnvironment) so it does not accumulate across warm-start runs that reuse the process.
🦋 Changeset detectedLatest commit: f00d362 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughThis PR replaces the bounded LRU-based idempotency key catalog (max 1000 entries) with an unbounded in-memory catalog to prevent silent metadata loss when a single run creates more than 1000 idempotency keys. The Sequence Diagram(s)Included above per checkpoint. Related Issues: None referenced. Related PRs: None referenced. Suggested labels: bug, core, cli-v3 Suggested reviewers: trigger.dev core maintainers familiar with idempotency key handling and worker run lifecycle. 🐰 A catalog once bounded tight, 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.ts (1)
11-25: 🚀 Performance & Scalability | 🔵 TrivialCorrect fix; note the removed memory ceiling.
Implementation is correct and matches the interface contract. One trade-off worth being aware of operationally: removing the LRU cap means memory usage for this catalog now scales linearly with the number of unique idempotency keys created in a single run, with no upper bound until
clear()fires at the run boundary. This is the intended fix and is already documented in the class comment, but if a run were to create an extreme number of keys (e.g. massive batch triggers), it could contribute to memory pressure in a long-lived worker process.packages/core/src/v3/idempotencyKeys.test.ts (1)
8-42: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider isolating catalog state between tests.
Both
itblocks share the same process-global catalog singleton; the first test leaves ~3000 entries behind since only the second test callsresetIdempotencyKeyCatalog(). Doesn't currently cause flakiness (hashes are unique per test), but adding anafterEach(() => resetIdempotencyKeyCatalog())would make the suite more robust to future additions/reordering.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c431acdd-f435-468e-ae73-12f58d67bd4a
📒 Files selected for processing (11)
.changeset/idempotency-key-catalog-eviction.mdpackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/core/src/v3/idempotency-key-catalog/lruIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotency-key-catalog/lruIdempotencyKeyCatalog.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotencyKeys.ts
💤 Files with no reviewable changes (2)
- packages/core/src/v3/idempotency-key-catalog/lruIdempotencyKeyCatalog.test.ts
- packages/core/src/v3/idempotency-key-catalog/lruIdempotencyKeyCatalog.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (38)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: sdk-compat / Node.js 22.12 (ubuntu-latest)
- GitHub Check: sdk-compat / Node.js 20.20 (ubuntu-latest)
- GitHub Check: sdk-compat / Cloudflare Workers
- GitHub Check: sdk-compat / Bun Runtime
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: sdk-compat / Deno Runtime
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/core/src/v3/idempotencyKeys.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
packages/core/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (packages/core/CLAUDE.md)
Never import the root package (
@trigger.dev/core). Always use subpath imports such as@trigger.dev/core/v3,@trigger.dev/core/v3/utils,@trigger.dev/core/logger, or@trigger.dev/core/schemas
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/core/src/v3/idempotencyKeys.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
packages/**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Use
pnpm run buildto verify changes in public packages (packages/*).
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
**/*.{test,spec}.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Place test files next to the source files they cover (for example,
MyService.ts->MyService.test.ts).
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.{ts,tsx,js,jsx}: Write unit tests with Vitest, keep test files beside the files under test, and use descriptivedescribeanditblocks.
Avoid mocks or stubs in tests; when Redis or Postgres are needed, use the helpers from@internal/testcontainers.
Files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.ts
packages/cli-v3/src/entryPoints/**/*
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
Code in
src/entryPoints/runs inside customer containers and is a different runtime environment from the CLI - changes affect deployed task execution directly
Files:
packages/cli-v3/src/entryPoints/dev-run-worker.tspackages/cli-v3/src/entryPoints/managed-run-worker.ts
🧠 Learnings (12)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In this repo’s trigger.dev codebase, the “never mock — use testcontainers” guideline should only be applied to integration tests that talk to real external services (e.g., Redis, Postgres, S2). For unit tests that validate in-memory logic (e.g., deduplication/cache behavior in StandardRealtimeStreamsManager and similar module-boundary call counting), it is allowed to use Vitest mocks like `vi.fn()` and to stub/mock `ApiClient` objects to count calls or simulate in-process collaborators. Do not flag `vi.fn()`-based mocks as policy violations in these unit-test scenarios; reserve the rule for true external-service integration tests.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.tspackages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.tspackages/core/src/v3/idempotency-key-catalog/catalog.tspackages/cli-v3/src/entryPoints/dev-run-worker.tspackages/core/src/v3/idempotency-key-catalog/index.tspackages/cli-v3/src/entryPoints/managed-run-worker.tspackages/core/src/v3/idempotencyKeys.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.tspackages/core/src/v3/idempotencyKeys.test.ts
🔇 Additional comments (7)
packages/cli-v3/src/entryPoints/dev-run-worker.ts (1)
38-38: LGTM!Also applies to: 382-382
packages/cli-v3/src/entryPoints/managed-run-worker.ts (1)
37-37: LGTM!Also applies to: 354-354
.changeset/idempotency-key-catalog-eviction.md (1)
1-7: LGTM!packages/core/src/v3/idempotency-key-catalog/catalog.ts (1)
8-12: LGTM!packages/core/src/v3/idempotency-key-catalog/inMemoryIdempotencyKeyCatalog.test.ts (1)
1-56: LGTM!packages/core/src/v3/idempotency-key-catalog/index.ts (1)
5-5: LGTM!Also applies to: 27-39
packages/core/src/v3/idempotencyKeys.ts (1)
41-50: LGTM!
myftija
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4046
Problem
When a single run creates more than 1000 idempotency keys (e.g. a large batch trigger where each item calls
idempotencyKeys.create()), the original key and scope metadata is silently dropped for all but the most recent 1000 keys.idempotencyKeys.create()returns a plain 64-char hash and stores the{ key, scope }mapping in an in-process catalog keyed by that hash. That catalog was a fixed-size LRU capped at 1000 entries. Once a run creates more than 1000 keys, the earliest mappings are evicted, so when the SDK later looks them up to attachidempotencyKeyOptionsto the trigger call, it finds nothing and sendsundefined. The affected runs then:ctx.run.idempotencyKeyas the raw hash instead of the user-provided keyidempotencyKeyScopeidempotency_key/idempotency_key_scopein the dashboard and analyticsDeduplication still works (the hash is intact); only the human-readable metadata is lost, which makes the failure silent and hard to notice.
Fix
resetExecutionEnvironment()(both dev and managed workers), matching how every other per-run manager is reset. Deployed workers reuse one process across many runs (warm starts), so this bounds memory to a single run's keys instead of accumulating across runs — which is the reason the size cap existed in the first place.Tests
mainand passes with the fix.clear().Verified:
@trigger.dev/coreandtrigger.devboth build; all idempotency tests pass. Changeset added (patch).