feat(run-ops): dedicated run-ops database package + docker service + migration runner#4113
feat(run-ops): dedicated run-ops database package + docker service + migration runner#4113d-cs wants to merge 6 commits into
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
internal-packages/run-ops-database/package.json (1)
18-21: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMove
prismaCLI todevDependencies.
prisma(the CLI) is only needed forgenerate/migrate/db:pushtooling, not at runtime; only@prisma/clientshould ship as a production dependency. Keeping the CLI independenciesunnecessarily bloats production installs.♻️ Proposed fix
"dependencies": { - "`@prisma/client`": "6.14.0", - "prisma": "6.14.0" + "`@prisma/client`": "6.14.0" }, "devDependencies": { + "prisma": "6.14.0", "rimraf": "6.0.1", "vitest": "4.1.7" },internal-packages/testcontainers/src/utils.ts (1)
61-73: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winHardcoded index DDL can drift from the source migration.
This raw SQL must stay byte-for-byte consistent with the actual
TaskRunWaitpointpartial-unique-index migration for the stated parity goal to hold. A future edit to that migration (renamed index, changed filter/columns) won't be caught here, silently letting test databases diverge from whatmigrate deployproduces in production.Consider deriving this statement from the migration file itself (e.g. read and extract the
CREATE UNIQUE INDEXline from20260630000000_task_run_waitpoint_null_batchindex_partial_unique/migration.sql) rather than duplicating the literal string, so future migration edits can't silently desync from this test helper.#!/bin/bash fd migration.sql internal-packages/run-ops-database/prisma/migrations --exec grep -n "TaskRunWaitpoint_taskRunId_waitpointId_batchIndex_null_key" {} \;internal-packages/testcontainers/src/index.ts (1)
184-238: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract shared PG17 container bootstrap helper.
getWorkerPostgresContainer17andgetRunOpsWorkerPostgresContainer17duplicate the container image, command flags,POSTGRES_INITDB_ARGS, and template-DB creation logic, differing only in which schema-push function runs at the end. Consider factoring the common bootstrap into a helper parameterized by the push function to avoid the two implementations drifting apart over time.♻️ Proposed refactor sketch
+async function bootstrapPg17TemplateContainer( + pushSchema: (url: string) => Promise<unknown> +): Promise<StartedPostgreSqlContainer> { + const container = await withCiResourceLimits(new PostgreSqlContainer("docker.io/postgres:17")) + .withCommand(["-c", "listen_addresses=*", "-c", "wal_level=logical"]) + .withEnvironment({ + POSTGRES_INITDB_ARGS: "--locale-provider=icu --icu-locale=en-US --encoding=UTF8", + }) + .start(); + const admin = new PrismaClient({ + datasources: { db: { url: postgresUriWithDatabase(container.getConnectionUri(), "postgres") } }, + }); + await admin.$executeRawUnsafe(`CREATE DATABASE "${POSTGRES_TEMPLATE_DB}"`); + await admin.$disconnect(); + await pushSchema(postgresUriWithDatabase(container.getConnectionUri(), POSTGRES_TEMPLATE_DB)); + return container; +} + let workerPostgresContainer17: Promise<StartedPostgreSqlContainer> | undefined; const getWorkerPostgresContainer17 = () => { if (!workerPostgresContainer17) { - workerPostgresContainer17 = (async () => { ... })(); + workerPostgresContainer17 = bootstrapPg17TemplateContainer(pushDatabaseSchema); } return workerPostgresContainer17; }; let runOpsWorkerPostgresContainer17: Promise<StartedPostgreSqlContainer> | undefined; const getRunOpsWorkerPostgresContainer17 = () => { if (!runOpsWorkerPostgresContainer17) { - runOpsWorkerPostgresContainer17 = (async () => { ... })(); + runOpsWorkerPostgresContainer17 = bootstrapPg17TemplateContainer(pushRunOpsSchema); } return runOpsWorkerPostgresContainer17; };
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 78448229-8888-4066-a6f9-b94ad9398070
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
.github/workflows/unit-tests-internal.ymldocker/Dockerfile.postgres17docker/docker-compose.ymlinternal-packages/run-ops-database/.envinternal-packages/run-ops-database/.gitignoreinternal-packages/run-ops-database/package.jsoninternal-packages/run-ops-database/prisma/migrations/20260629174132_init/migration.sqlinternal-packages/run-ops-database/prisma/migrations/20260630000000_task_run_waitpoint_null_batchindex_partial_unique/migration.sqlinternal-packages/run-ops-database/prisma/migrations/migration_lock.tomlinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/run-ops-database/prisma/schema.prismainternal-packages/run-ops-database/src/index.tsinternal-packages/run-ops-database/tsconfig.jsoninternal-packages/run-ops-database/vitest.config.tsinternal-packages/testcontainers/package.jsoninternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
**/Dockerfile*
📄 CodeRabbit inference engine (CLAUDE.md)
When updating Docker image references, always use multiplatform/index digests, not architecture-specific digests.
Files:
docker/Dockerfile.postgres17
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Place test files next to the source files they cover (for example,
MyService.ts->MyService.test.ts).
Files:
internal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.{ts,tsx,js,jsx}: Write unit tests with Vitest, keep test files beside the files under test, and use descriptivedescribeanditblocks.
Avoid mocks or stubs in tests; when Redis or Postgres are needed, use the helpers from@internal/testcontainers.
Files:
internal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
**/tsconfig.json
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use strict mode in TypeScript configuration
Files:
internal-packages/run-ops-database/tsconfig.json
**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
When adding
zodto any package, use the exact repository-pinned version (3.25.76) and never a different version or a range.
Files:
internal-packages/run-ops-database/package.jsoninternal-packages/testcontainers/package.json
🧠 Learnings (14)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-ops-database/src/index.tsinternal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/vitest.config.tsinternal-packages/run-ops-database/prisma/schema.parity.test.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/utils.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/testcontainers/src/heteroDedicated.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-05-01T15:45:08.099Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3499
File: packages/plugins/tsup.config.ts:3-3
Timestamp: 2026-05-01T15:45:08.099Z
Learning: In build/tool configuration files (e.g., tsup.config.ts, vite.config.ts, vitest.config.ts), follow the tool’s documented export pattern and use `export default defineConfig(...)` (or the equivalent documented default export). The repo-wide guideline “use named exports instead of default exports” should apply only to application code (*.{ts,tsx,js,jsx}), not to these build/tool config files—so do not flag `export default defineConfig(...)` in these config files as a violation.
Applied to files:
internal-packages/run-ops-database/vitest.config.ts
📚 Learning: 2026-06-19T15:46:48.405Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3990
File: internal-packages/run-store/tsconfig.json:3-7
Timestamp: 2026-06-19T15:46:48.405Z
Learning: In the trigger.dev monorepo, internal packages use a TS project-references layout: the package root `tsconfig.json` should be references-only (its `references` should point to `tsconfig.src.json` and `tsconfig.test.json`, and it should intentionally be inert as a compile target). In this setup, the root `tsconfig.json` may omit compiler options like `strict`, because the actual compilation of `src/**` happens via `tsconfig.src.json`. During code review, do not flag the package root `tsconfig.json` for missing `strict` mode when it is intentionally references-only and `strict: true` is set in `tsconfig.src.json` (the file that is referenced and actually used for building `src/**`).
Applied to files:
internal-packages/run-ops-database/tsconfig.json
📚 Learning: 2026-04-30T21:28:35.705Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3473
File: internal-packages/database/prisma/schema.prisma:59-60
Timestamp: 2026-04-30T21:28:35.705Z
Learning: When reviewing Prisma schema files in this repository, do not suggest using Prisma’s `@check` model/table-level attribute or any native Prisma schema syntax for CHECK constraints. Prisma does not implement CHECK constraints (see prisma/prisma#3388). If a CHECK constraint is required, add it only via raw SQL in a handwritten migration (e.g., `ALTER TABLE ... ADD CONSTRAINT ... CHECK (...)`).
Applied to files:
internal-packages/run-ops-database/prisma/schema.prisma
🪛 ast-grep (0.44.0)
internal-packages/run-ops-database/prisma/schema.parity.test.ts
[warning] 31-33: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(
@relation[^\\n]*\\b${model}\\b|\\b${model}\\b[^\\n]*@relation``
)
Note: [CWE-1333] Inefficient Regular Expression Complexity
(regexp-from-variable)
[warning] 35-35: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(\\s${model}(\\?|\\[\\])?\\s)
Note: [CWE-1333] Inefficient Regular Expression Complexity
(regexp-from-variable)
[warning] 57-57: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(model ${m} \\{)
Note: [CWE-1333] Inefficient Regular Expression Complexity
(regexp-from-variable)
🔇 Additional comments (19)
docker/Dockerfile.postgres17 (1)
1-5: LGTM!docker/docker-compose.yml (1)
14-14: LGTM!Also applies to: 55-84
internal-packages/run-ops-database/prisma/schema.prisma (2)
44-982: LGTM! Model definitions, FK conventions, and column/type choices are internally consistent with the accompanying migration files.
7-12: 🎯 Functional CorrectnessNo change needed This generator block intentionally matches
internal-packages/database/prisma/schema.prisma.internal-packages/run-ops-database/prisma/migrations/20260629174132_init/migration.sql (1)
1-622: LGTM!internal-packages/run-ops-database/prisma/migrations/20260630000000_task_run_waitpoint_null_batchindex_partial_unique/migration.sql (1)
1-6: LGTM! Correctly implemented as a raw SQL migration for the partial index Prisma can't express natively.internal-packages/run-ops-database/prisma/migrations/migration_lock.toml (1)
1-4: LGTM!.github/workflows/unit-tests-internal.yml (1)
98-98: LGTM!internal-packages/run-ops-database/package.json (1)
1-39: LGTM!internal-packages/run-ops-database/tsconfig.json (1)
1-14: LGTM!internal-packages/run-ops-database/vitest.config.ts (1)
1-10: LGTM!internal-packages/run-ops-database/.env (1)
1-1: LGTM!internal-packages/run-ops-database/.gitignore (1)
1-7: LGTM!internal-packages/run-ops-database/src/index.ts (1)
1-4: LGTM!internal-packages/testcontainers/src/utils.ts (2)
140-159: LGTM!
40-59: 🎯 Functional CorrectnessNo change needed
@internal/run-ops-databasealready exports./prisma/schema.prisma(and./prisma/*), sorequire.resolve("@internal/run-ops-database/prisma/schema.prisma")is valid.> Likely an incorrect or invalid review comment.internal-packages/testcontainers/package.json (1)
22-22: LGTM!internal-packages/testcontainers/src/index.ts (1)
1-4: LGTM!Also applies to: 15-15, 337-459
internal-packages/testcontainers/src/heteroDedicated.test.ts (1)
1-27: LGTM!
d-cs
force-pushed
the
runops/pr02-db-foundation
branch
from
32525bb to
9b2b67d
Compare
|
Thanks for the review. On the three nitpicks:
|
…migration runner Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ndation The db-foundation change dropped createElectricContainer, the electricOrigin fixture, the ContainerWithElectric* context types, and the containerWithElectricTest / containerWithElectricAndRedisTest fixtures. That Electric infra is unrelated to the run-ops db split, is being sunset on its own track, and is still consumed by apps/webapp/test/realtimeClient.test.ts (which imports containerWithElectricAndRedisTest) — so its removal here also broke that import. Restore it verbatim; the new PG17 run-ops fixtures are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The run-ops database is migrated first-class by the @internal/run-ops-database package's own prisma migrate deploy (its schema.prisma datasource reads RUN_OPS_DATABASE_URL and it owns its own migrations dir), which the root db:migrate already sweeps via turbo. The bespoke script instead ran prisma migrate deploy from the control-plane database package against the run-ops DB, applying the full control-plane migration history rather than the run-ops subset — redundant with the native flow and wrong. Drop the script and its two script entries (root package.json, database package.json). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e schema Rework the run-ops schema comments so they read as documentation rather than working notes. Replaces the top-of-file header with prose describing the subset relationship and the three relation-handling rules, adds a short header above each model stating how it differs from its control-plane counterpart (which relations are scalar-only FKs, which are FK-free join models, which stay as real FKs), and removes the stale group-(A)/group-(B)/"drop" tags. Comments only; no model, field, type, attribute, index, or enum is changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…17 fixture bootstrap Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d-cs
force-pushed
the
runops/pr02-db-foundation
branch
from
d1fd926 to
dc3d806
Compare
1 participant
What
The dedicated run-ops database foundation for the split: a standalone Prisma package plus the infra to run and migrate it.
internal-packages/run-ops-database— a new Prisma package (@internal/run-ops-database) whose schema mirrors the run-execution tables that will live on the dedicated DB, with its own generated client, migrations, and migration runner.prisma/schema.parity.test.ts— a parity test that guards the run-ops schema against drift from the control-plane schema for the mirrored tables.docker/Dockerfile.postgres17,docker/docker-compose.yml) so the dedicated DB is available locally under the run-ops compose profile.Why
This is the second PR in the run-ops split stack, stacked on the core primitives. It stands up the dedicated database and its tooling. There is no runtime wiring into the webapp here — the app does not read or write this DB yet; that arrives in later PRs. On its own this PR only adds a package, a docker service, and test fixtures.
Tests
Schema-parity test for the run-ops schema; hetero testcontainer fixture smoke test.
Notes
runops/pr01-core-residency). Review that one first; this diff is against it.🤖 Generated with Claude Code