Skip to content

2021-March-07 - Prerelease - 2.6.77@baa2019b0c

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 07 Mar 19:09
baa2019
Fix victory bonds technology (#8993)

The correct name for the technology is actually 'warBonds' though
two maps used the name 'victoryBonds'. Previously it was working
arguably happenstance where the code scanned all techs for the
war bonds bonus values and then used those (without looking at
the name).

In cc6de441 a filter was introduced that first filtered technologies
by name (looking for 'warBonds') and only used the war bond attribute
properties from that specific tech. This meant maps with an incorrect
naming for 'warBonds' no longer worked.

This update restores the previous behavior and removes the filter,
any technology with the warbonds bonuses will be picked up and
are additive. This means a person can design multiple technologies
that give a stacking war bonds bonus. Of note, any of the 'dice sides'
attributes may be used, if there are multiple war bonds technologies
then they should all use the same 'dice sides' bonus.

Fixes:
- https://github.com/triplea-game/triplea/issues/6792
- https://github.com/triplea-game/triplea/issues/8609

Problem introduced in: cc6de441db25348ebe74e6a590f23b6b7295f55d