Skip to content

2026-May-08 - 2.7.15500

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 08 May 04:27
c0faad1
fix(NPE): resolve NPE for gamePlayer with null data (#14351)

* fix(NPE): resolve NPE for gamePlayer with null data

To repro: save a game of greyhawk_wars in 2.5, load
in 2.7. Proceed through, select at least one of the
"I am a human" buttons, then proceed. Note at the
start of the next turn, NPE.

Cause: the 2.5 save attaches a null GameData to the GamePlayer
for neutrals. In this map we have a tech attachment that touches
the nuetrals, which then tries to fetch a game data.

Fix: add a static gameData accessible to places that just
need a reference to the live game data. A lot of care
is needed when using this, we clone game entities like
crazy and should be sure that the clones use the cloned
game data, not the live copy.

Fixes#13685

* Fix, use fallback; sometimes we grab gamedata during parse time..