Refactor SharpAssemblyResolver.Builder to use Dictionary - #4
Merged
Conversation
Modified SharpAssemblyResolver.Builder to use a Dictionary for assembly paths, enabling mapping of assembly names to full paths. Updated ToAssemblyResolver method to pass dictionary values to the constructor. Enhanced AddReferenceFile method to log warnings when overwriting existing assembly paths. Added unit tests to verify logging behavior. Introduced TestLogger class for capturing warning messages in tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 81.39% 82.69% +1.30%
==========================================
Files 17 17
Lines 473 497 +24
Branches 58 60 +2
==========================================
+ Hits 385 411 +26
+ Misses 69 67 -2
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified SharpAssemblyResolver.Builder to use a Dictionary for assembly paths, enabling mapping of assembly names to full paths. Updated ToAssemblyResolver method to pass dictionary values to the constructor. Enhanced AddReferenceFile method to log warnings when overwriting existing assembly paths. Added unit tests to verify logging behavior. Introduced TestLogger class for capturing warning messages in tests.