ci: fix S3 artifact handoff#139
Merged
CodeNinjaEvan merged 1 commit intoJul 22, 2026
Merged
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
yanghang8612
marked this pull request as ready for review
July 22, 2026 06:15
CodeNinjaEvan
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upload-to-s3specifically to the self-hostedfor-linuxrunneractions/upload-artifactfrom v4 to the Node.js 24-based v6actions/download-artifactfrom v4 to the Node.js 24-based v7Root cause
The S3 job used only
[self-hosted, Linux], which also matched the Emscripten runner. Run 29890009976 was therefore assigned to runneremsinstead of runnerlinux.The first artifact download reached the Azure Blob redirect but failed to download and extract the artifact after five retries. The upload step was never reached, so this failure was unrelated to S3 credentials.
The same run also warned that
actions/upload-artifact@v4andactions/download-artifact@v4target deprecated Node.js 20. The runner forced those actions onto Node.js 24, producing additionalpunycodeandBuffer()deprecation warnings.Impact
emsrunnerValidation
actionlintpassed with the repository's known customfor-linuxrunner label allowedgit diff --checkpassedFailed production run: https://github.com/tronprotocol/solidity/actions/runs/29890009976