Skip to content

ci: use production S3 bucket for binary uploads#140

Merged
CodeNinjaEvan merged 1 commit into
tronprotocol:release_0.8.31from
yanghang8612:ci/use-production-s3-bucket
Jul 22, 2026
Merged

ci: use production S3 bucket for binary uploads#140
CodeNinjaEvan merged 1 commit into
tronprotocol:release_0.8.31from
yanghang8612:ci/use-production-s3-bucket

Conversation

@yanghang8612

Copy link
Copy Markdown

Summary

  • route all binary uploads to the production S3 bucket
  • remove the release-branch selection of the test bucket
  • keep the existing commit-SHA object prefix unchanged

Why

The upload pipeline no longer distinguishes between production and test environments. Release branches should therefore use S3_BUCKET_PROD instead of S3_BUCKET_TEST. This also avoids the KMS authorization failure encountered when uploading to the test bucket.

Impact

Both develop and release_* workflow runs upload release artifacts to the production bucket under ${{ github.sha }}/.

Validation

  • parsed .github/workflows/build.yml as YAML
  • ran git diff --check
  • confirmed the commit changes only .github/workflows/build.yml

@github-actions

Copy link
Copy Markdown

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@yanghang8612
yanghang8612 marked this pull request as ready for review July 22, 2026 07:37
@CodeNinjaEvan
CodeNinjaEvan merged commit 03423cb into tronprotocol:release_0.8.31 Jul 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants