Skip to content

optimize the logic of scanning blocks #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skipjack8 merged 1 commit into from
Sep 24, 2020
Merged

optimize the logic of scanning blocks #370

skipjack8 merged 1 commit into from
Sep 24, 2020

Conversation

@skipjack8
Copy link
Contributor

@skipjack8 skipjack8 commented Aug 27, 2020

What does this PR do?
Optimize the logic of scanning blocks.

  1. Add a configuration item to set the starting block that the wallet to scan.
  2. Reduce the number of blocks to request to fullnode, from 1000 to 200 at a time.

Why are these changes required?
Speed up synchronization time of shielded TRC20 transaction.

This PR has been tested by:

Manual Testing
Follow up

Extra details

@skipjack8 skipjack8 closed this Aug 27, 2020
@skipjack8 skipjack8 reopened this Sep 24, 2020
@waynercheung waynercheung self-requested a review September 24, 2020 08:32
@skipjack8 skipjack8 merged commit 2f04b59 into release_v4.1 Sep 24, 2020
@skipjack8 skipjack8 deleted the hotfix/optimize_scan_block branch January 4, 2021 08:52
@Akaslove99 Akaslove99 mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@waynercheung waynercheung waynercheung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skipjack8 @waynercheung