Closed
Conversation
gummy789j
added a commit
to parsoncryptoai/wallet-cli
that referenced
this pull request
Apr 16, 2026
…ling, and code hygiene - tronprotocol#2: Preserve specific Ledger signing error messages instead of overwriting with generic Transaction signing failed - tronprotocol#3: Add requirePositive validation for exchange-create balances - tronprotocol#4: Add requireNonNegative validation for update-asset limits - tronprotocol#5: Use validated address bytes via encode58Check instead of discarding getAddress() return values in delegated-resource queries - tronprotocol#7: Validate witness addresses in vote-witness before submission - tronprotocol#8: Validate mnemonic word count (12/24) in register-wallet using existing MnemonicUtils utility - tronprotocol#9: Specify StandardCharsets.UTF_8 in all String.getBytes() calls (47 occurrences across 12 files) - tronprotocol#13: Make resolveActiveWalletFileStrict throw IOException instead of returning null, matching its Strict contract - tronprotocol#17: Add requireNonNegative check for permission-id on 6 commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds webpack to the toolchain
It doesn't bundle anything yet, assets should gradually move to using webpack.