Skip to content

Fix: consume http request on missing handler#54

Merged
trpc-admin merged 2 commits into
trpc-group:mainfrom
NewbieOrange:fix/http_consume_notfound
Oct 20, 2023
Merged

Fix: consume http request on missing handler#54
trpc-admin merged 2 commits into
trpc-group:mainfrom
NewbieOrange:fix/http_consume_notfound

Conversation

@NewbieOrange

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Oct 20, 2023

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NewbieOrange

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Oct 20, 2023

@liucf3995 liucf3995 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Oct 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #54 (0544309) into main (b301f77) will decrease coverage by 0.03378%.
Report is 1 commits behind head on main.
The diff coverage is 100.00000%.

❗ Current head 0544309 differs from pull request most recent head 63377e2. Consider uploading reports for the commit 63377e2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #54         +/-   ##
===================================================
- Coverage   81.64642%   81.61264%   -0.03379%     
===================================================
  Files            854         854                 
  Lines          33661       33659          -2     
===================================================
- Hits           27483       27470         -13     
- Misses          6178        6189         +11     
Files Coverage Δ
trpc/server/http_service.cc 41.30435% <100.00000%> (-0.18501%) ⬇️

... and 5 files with indirect coverage changes

@trpc-admin
trpc-admin merged commit 50f7742 into trpc-group:main Oct 20, 2023
@NewbieOrange
NewbieOrange deleted the fix/http_consume_notfound branch October 20, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants