Skip to content

BugFix: Fix some problems at stream invoking#60

Merged
helloopenworld merged 1 commit into
trpc-group:mainfrom
weimch:dev
Oct 25, 2023
Merged

BugFix: Fix some problems at stream invoking#60
helloopenworld merged 1 commit into
trpc-group:mainfrom
weimch:dev

Conversation

@weimch

@weimch weimch commented Oct 23, 2023

Copy link
Copy Markdown
Contributor
  • fix stream crash at ServerContext because it has been moved
  • fix stream transinfo not pass into ServerContext

@github-actions

github-actions Bot commented Oct 23, 2023

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@weimch

weimch commented Oct 23, 2023

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Oct 23, 2023
@codecov

codecov Bot commented Oct 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #60 (86d0150) into main (41485d6) will increase coverage by 0.03615%.
Report is 1 commits behind head on main.
The diff coverage is 100.00000%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #60         +/-   ##
===================================================
+ Coverage   81.61992%   81.65607%   +0.03615%     
===================================================
  Files            854         854                 
  Lines          33656       33646         -10     
===================================================
+ Hits           27470       27474          +4     
+ Misses          6186        6172         -14     
Files Coverage Δ
trpc/client/make_client_context.cc 83.05085% <ø> (+16.83462%) ⬆️
trpc/client/service_proxy.cc 77.74799% <100.00000%> (+0.11996%) ⬆️
trpc/stream/grpc/grpc_server_stream_handler.cc 62.50000% <100.00000%> (ø)
trpc/stream/http/async/server/stream_handler.cc 100.00000% <100.00000%> (ø)
trpc/stream/trpc/trpc_server_stream.cc 95.38462% <100.00000%> (+0.10903%) ⬆️
trpc/stream/trpc/trpc_server_stream_handler.cc 90.47619% <100.00000%> (ø)

... and 8 files with indirect coverage changes

- fix stream crash at ServerContext because it has been moved
- fix stream transinfo not pass into ServerContext
- delete deprecated interface and useless code in trpc/client/make_client_context.h/.cc
@helloopenworld
helloopenworld merged commit 3d299f7 into trpc-group:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants