feat(conformance): publish the report-only corpus in the summary - #836
Merged
Conversation
conformance-summary.json published only the enforced corpus. The
report-only corpus went to the test log and nowhere else, so anything
downstream that wanted the whole picture had to hard-code figures read
out of local test output — which goes stale the moment someone fixes a
gap, silently, with nothing to catch it.
It is now collected into its own bucket and published as a sibling of
`overall`:
"overall": { "passed": 10646, "total": 10649 },
"tracked": { "passed": 2025, "total": 2236 }
Deliberately not folded into `overall`. `overall` is what the README
badge asserts — the enforced suite passes — and folding these rows in
would take that badge from 100.0% to 98.3% as a side effect of a
refactor. A consumer that wants everything adds the two.
Collected through the same path as every enforced category, so the two
halves are comparable. The report-only runner's console figure differs
because it evaluates volatile formulas against a pinned clock where the
collector skips them; publishing that number beside a collector-derived
`overall` would be mixing methods.
Closes #835
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Test Coverage by Category
✓ = 100% passing · ⚠ = known deviation · The ~79,590 total counts formula evaluations (each conformance row and each property case = 1). GitHub Checks reports 3,797 Rust test functions: 2,941 unit + 159 property functions (shown as cases above) + 697 conformance/integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #835.
conformance-summary.jsonpublished only the enforced corpus. The report-only corpus went to the test log and nowhere else — so anything downstream that wanted the whole picture had to hard-code figures read out of local test output. That is already happening on the marketing site, and it goes stale the moment someone fixes a gap, silently, with nothing to catch it.It is now published as a sibling of
overall:Why not fold it into
overallBecause
overallis what the README badge asserts — the enforced suite passes — and folding these rows in would take that badge from 100.0% to 98.3% as a side effect of a refactor. That may well be a change worth making, but it should be a decision, not something that falls out of a plumbing PR. A consumer that wants the full picture adds the two numbers; the point here is only that both come from one file.Say the word and I'll do the badge change as a one-line follow-up.
Why the collector, not the runner
The two paths count differently. The report-only runner prints
2055/2235; the collector gives2025/2236, because the runner evaluates volatile formulas against a pinned clock where the collector skips them.overallis collector-derived — its10646/10649matches the published badge exactly — sotrackedhas to be too. Publishing a runner-derived figure next to a collector-derived one would be mixing methods in a single object, and any consumer adding them would get a number that means nothing.Verification
overallbyte-identical to before, so the badge and the published report page are untouched.overall10646/10649,tracked2025/2236, combined 12671/12885 = 98.34%.trackedisOption, and the CI step is guarded, so a report without it still produces a valid summary.Follow-up on my side once this lands: the marketing site drops its hard-coded constant and reads this file.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.