Skip to content

feat: make available kwil gateway binary in ec2 instance#140

Closed
VladislavSpassov wants to merge 2 commits into
mainfrom
feat/fetch-kwil-gateway-binary-from-s3
Closed

feat: make available kwil gateway binary in ec2 instance#140
VladislavSpassov wants to merge 2 commits into
mainfrom
feat/fetch-kwil-gateway-binary-from-s3

Conversation

@VladislavSpassov
Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (including inline docs)
  • Other (please describe):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Checklist Explanation:

How to Review this PR:

Additional Information:

@VladislavSpassov VladislavSpassov changed the title make available kwil gateway binary in ec2 instance feat: make available kwil gateway binary in ec2 instance Mar 20, 2024
Comment thread truflation/infra/cdk_main.go
@MicBun
Copy link
Copy Markdown
Contributor

MicBun commented Mar 20, 2024

Hi @VladislavSpassov, we are currently using branch refactor/upgrade-zero-seven from #117. Our latest updated code is in there, please refrain from using main for the time being.

@VladislavSpassov
Copy link
Copy Markdown
Contributor Author

Hi @VladislavSpassov, we are currently using branch refactor/upgrade-zero-seven from #117. Our latest updated code is in there, please refrain from using main for the time being.

@MicBun Thanks for the info. I see that you will soon merge the branch into main. Would it make still sense to branch out from refactor/upgrade-zero-seven?

@MicBun
Copy link
Copy Markdown
Contributor

MicBun commented Mar 20, 2024

Would it make still sense to branch out from refactor/upgrade-zero-seven?

@VladislavSpassov
the main branch will be completely replaced anyway(it is a full refactor) , it should be okay to branch out from refactor/upgrade-zero-seven

@outerlook
Copy link
Copy Markdown
Contributor

Hey @VladislavSpassov,
before recent pushes there were no cdk at that branch. Now there is. It's located under deployments/infra. The structure is the same.

To help, the only difference is that we're now using AWS Linux 2 image. Then, scripts that use apt-get would need to be adapted, but I don't think that's the case here.

@VladislavSpassov
Copy link
Copy Markdown
Contributor Author

moving the pr to #141

@outerlook outerlook deleted the feat/fetch-kwil-gateway-binary-from-s3 branch March 25, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants