Add Poetry actions#229
Closed
EliSchleifer wants to merge 9 commits into
Closed
Conversation
Member
Author
|
There is a bug we've identified that blocks a commit when all the poetry actions are enabled as defined. The trunk team is actively investigating. |
|
Breakpoint trunk-plugins-action-tests was triggered on exit. Click here to connect to the session. |
TylerJang27
added a commit
that referenced
this pull request
Mar 27, 2024
- Upgrade trunk and bump the minimum required version - This will unblock #229 - This will fix some of the Windows [nightly issues](https://github.com/trunk-io/plugins/actions/runs/8448489088/job/23140665928) (I'll queue a job after this lands) - This will fix the [check nightly](https://github.com/trunk-io/.trunk/actions/runs/8355518290/job/22870763034) runs (I'll queue a job after this lands) - This will add PHP runtime support (soon) - Note there is one rare daemon lifetime bug that will need a fast follow-up upgrade fix - buildifier released [7.1.0](https://github.com/bazelbuild/buildtools/releases/tag/v7.1.0), which mandates `load` sorting as a formatting fix - trufflehog released [3.71.1](https://github.com/trufflesecurity/trufflehog/releases/tag/v3.71.1), which no longer lints symlinks, so we have to use `copy_targets` and cache results to generate a sandbox (`cache_ttl` does not imply `cache_results` currently) Note that we will need to have a prod CLI release before we can next release plugins (minor version bump)
Merged
TylerJang27
added a commit
that referenced
this pull request
Mar 27, 2024
Dupe of #229. Adds poetry Trunk Actions to match parity with [pre-commit](https://python-poetry.org/docs/pre-commit-hooks/). Note that the non-hermetic story is much cleaner at time of writing, with the hermetic story blocked by not being able to unset `VIRTUAL_ENV` in the Action and Tool. In other words, for now recommended behavior requires manual [Poetry installation](https://python-poetry.org/docs/#installation). We've added a tool test and several actions tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
poetryTrunk Actions to match parity withpre-commit. Note that the non-hermetic story is much cleaner at time of writing, with the hermetic story blocked by not being able to unsetVIRTUAL_ENVin the Action and Tool. In other words, for now recommended behavior requires manual Poetry installation.We've added a tool test and several actions tests. PR taken up by @TylerJang27