Skip to content

Upgrade trunk, fix trufflehog and buildifier#716

Merged
TylerJang27 merged 3 commits into
mainfrom
tyler/upgrade-with-fixes
Mar 27, 2024
Merged

Upgrade trunk, fix trufflehog and buildifier#716
TylerJang27 merged 3 commits into
mainfrom
tyler/upgrade-with-fixes

Conversation

@TylerJang27
Copy link
Copy Markdown
Collaborator

@TylerJang27 TylerJang27 commented Mar 27, 2024

  • Upgrade trunk and bump the minimum required version
    • This will unblock Add Poetry actions #229
    • This will fix some of the Windows nightly issues (I'll queue a job after this lands)
    • This will fix the check nightly runs (I'll queue a job after this lands)
    • This will add PHP runtime support (soon)
    • Note there is one rare daemon lifetime bug that will need a fast follow-up upgrade fix
  • buildifier released 7.1.0, which mandates load sorting as a formatting fix
  • trufflehog released 3.71.1, which no longer lints symlinks, so we have to use copy_targets and cache results to generate a sandbox (cache_ttl does not imply cache_results currently)

Note that we will need to have a prod CLI release before we can next release plugins (minor version bump)

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 27, 2024

⏱️ 26m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests macOS 7m 🟩
Tool Tests (macOS) 5m 🟥🟥
Windows Linter Tests 5m 🟩
Linter Tests Linux 4m 🟩
CodeQL-Build 1m 🟩
Trunk Check runner [linux] 1m 🟩
Tool Tests (Linux) 1m 🟩
Action Tests 53s 🟩
Repo Tests / Plugin Tests 27s 🟩
Detect changed files 11s 🟩
Aggregate Test Results 5s 🟥🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review March 27, 2024 18:37
@TylerJang27 TylerJang27 requested review from det and laurit17 March 27, 2024 18:37
@TylerJang27 TylerJang27 merged commit a390bcd into main Mar 27, 2024
@TylerJang27 TylerJang27 deleted the tyler/upgrade-with-fixes branch March 27, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants