feat: add deriveCredential for holder - #647
Merged
Merged
Conversation
fqutishat
commented
Mar 3, 2021
| } | ||
|
|
||
| // DeriveCredentialRequest is request for deriving credential. | ||
| type DeriveCredentialRequest struct { |
Author
There was a problem hiding this comment.
@troyronda @sudeshrshetty derive request doesn't have nonce field in vc-http-api w3c/vcalm@a8cb2d0#diff-74dfbc770d6e21cb974f297ba8f1bc7015ece556537a6202e87b78622728a0cfR562
Contributor
There was a problem hiding this comment.
I think we should add an option for nonce, so that we have an HTTP API that can handle the full derivation scope.
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
==========================================
+ Coverage 86.41% 86.42% +0.01%
==========================================
Files 51 51
Lines 4504 4537 +33
==========================================
+ Hits 3892 3921 +29
- Misses 359 362 +3
- Partials 253 254 +1
Continue to review full report at Codecov.
|
sudeshrshetty
approved these changes
Mar 3, 2021
fqutishat
force-pushed
the
update
branch
2 times, most recently
from
March 3, 2021 12:41
37b33f7 to
d49a1fa
Compare
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
troyronda
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Firas Qutishat firas.qutishat@securekey.com