Skip to content

dependabot: Block cert-manager - #333

Open
Jakob-Naucke wants to merge 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:block-cert-manager
Open

dependabot: Block cert-manager#333
Jakob-Naucke wants to merge 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:block-cert-manager

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Aug 11, 2026

Copy link
Copy Markdown
Member

With our goal to stay on k8s 1.35 for easier downstreaming, cert-manager must also be blocked or 1.36 will be pulled as transitive dependency.

Summary by Sourcery

Build:

  • Update Dependabot configuration to restrict cert-manager version upgrades to 1.21 or higher without advancing Kubernetes beyond 1.35.

With our goal to stay on k8s 1.35 for easier downstreaming,
cert-manager must also be blocked or 1.36 will be pulled as transitive
dependency.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jakob-Naucke

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Dependabot configuration to block cert-manager upgrades beyond version 1.21 in order to prevent pulling Kubernetes 1.36 as a transitive dependency and keep the stack aligned with Kubernetes 1.35.

Flow diagram for Dependabot blocking cert-manager upgrades

flowchart LR
  Dependabot[Dependabot Go module updates]
  Config[dependabot.yml ignore rule]
  CertManager[Dependency github.com/cert-manager/cert-manager]
  K8s135[Kubernetes 1.35 compatible]
  K8s136[Kubernetes 1.36 transitive dependency]

  Dependabot --> CertManager
  CertManager --> Config
  Config -->|ignore versions >= 1.21| Dependabot
  CertManager -->|kept <= 1.21| K8s135
  CertManager -.-|blocked >= 1.21| K8s136
Loading

File-Level Changes

Change Details Files
Configure Dependabot to ignore cert-manager versions >= 1.21 for Go module updates to avoid pulling Kubernetes 1.36 transitively.
  • Add a new ignore rule for the cert-manager Go module dependency.
  • Specify a version constraint (>=1.21) under the existing Go module updates configuration so Dependabot will not propose PRs for newer cert-manager versions.
.github/dependabot.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant